unixPB: Install gcc 10.3 into /usr/local/gcc10

[sxa]

Fixes #2386

Signed-off-by: Stewart X Addison [email protected]

Checklist

• commit message has one of the standard prefixes
• faq.md updated if appropriate
• other documentation is changed or added (if applicable)
• playbook changes run through VPC or QPC (if you have access) VPC / QPC
• for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Change to testVPC.sh was due to a bug when building later JDKs which made the process pick up the static-libs directory instead of the JDK, which causd a test failure (described in the comments below)

[sxa]

macos check failure was a connection timeout downloading ant. Solaris check failure was an issue downloading the vagrant box, so neither are related to this PR.

[Willsparker]

whoops, I didn't consider the GitHub check when doing #2405 . Thanks for bringing it up :-)

[sxa]

Changes look good in VPC, although there's a problem showing up when it tries to run the tests - however it does not look related to this PR. https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/1366/OS=CentOS6,label=vagrant/console

18:42:34 (ant -f ./scripts/build_tools.xml -DTEST_JDK_HOME=/home/vagrant/openjdk-build/workspace/build/src/build/linux-x86_64-server-release/images/jdk-17.0.1+12-static-libs
18:42:34 /bin/sh: -c: line 3: syntax error: unexpected end of file
18:42:34 makefile:94: recipe for target 'compileTools' failed
18:42:34 make: *** [compileTools] Error 1
18:42:34 JAVA_HOME is set to /home/vagrant/openjdk-build/workspace/build/src/build/linux-x86_64-server-release/images/jdk-17.0.1+12-static-libs
18:42:34 /home/vagrant/openjdk-build/workspace/build/src/build/linux-x86_64-server-release/images/jdk-17.0.1+12
18:42:34 make -f makeGen.mk AUTO_DETECT= MODE=tests TESTTARGET=MBCS_Tests_pref_ja_JP_linux_0 TESTLIST=
18:42:34 make[1]: Entering directory '/home/vagrant/testLocation/aqa-tests/TKG'
18:42:34 perl scripts/configure.pl
18:42:34 /home/vagrant/openjdk-build/workspace/build/src/build/linux-x86_64-server-release/images/jdk-17.0.1+12-static-libs
18:42:34 make[1]: execvp: /home/vagrant/openjdk-build/workspace/build/src/build/linux-x86_64-server-release/images/jdk-17.0.1+12-static-libs: Permission denied
18:42:34 makeGen.mk:45: recipe for target 'autogen' failed
18:42:34 make[1]: *** [autogen] Error 127
18:42:34 make[1]: Leaving directory '/home/vagrant/testLocation/aqa-tests/TKG'
18:42:34 makefile:49: recipe for target '_MBCS_Tests_pref_ja_JP_linux_0' failed
18:42:34 make: *** [_MBCS_Tests_pref_ja_JP_linux_0] Error 2
18:42:34 ++ date +%T

[sxa]

ansible_lint check is now failing regardless of this PR, so should not hold things up ...

[Willsparker]

LGTM - Looking at VPC-1366, there was a successful JDK17 build on CentOS6/x84, using GCC-10. The testing failed, and we're looking more into that, however I don't think that is related to this PR. Same case with the Linter, that appears to be failing due to something other than the syntax of this PR.

[sxa]

I think all the github check failures are now determined to be unrelated to this PR. I've got a final VPC run at https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/1370 and if that's ok (other than the test execution failure which also appears unrelated to this PR - https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/1367 is a run from the master branches to check if it happens there too) then I'll merge.

[sxa]

@Willsparker Can you re-review please? I've made a change to testJDK.sh. Unclear why this PR has shown it up but it looks like the line before the sh error shows that it picked up images/jdk-17.0.1+12-static-libs instead of images/jdk-17.0.1+12 which is the likely cause of the test case failure.

I've edited the VPC job to explicitly clone from my branch to test this.

[Willsparker]

LGTM

[sxa]

Chnage to testJDK.sh resolves the unexpected end of file error described above - the ant line should not have bene pointing at the static-ibs directory.

[sxa]

Converting this back to draft as the MBCS test is failing to pass when the build is performed with GCC10

• Working build (CentOS7) (NOTE: This was JDK8 - conclusion may be invalid)
• Failing build (CentOS8)

[sxa]

Problem with the MBCS test on JDK17 will be resolved by eclipse-openj9/openj9#14212. [VPC 1381] worked on JDK8 with GCC 10.3 so I'm comfortable that this is now safe so I will merge :-)