Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragonwell Windows everywhere #2376

Merged
merged 3 commits into from
Jan 13, 2021
Merged

Dragonwell Windows everywhere #2376

merged 3 commits into from
Jan 13, 2021

Conversation

sxa
Copy link
Member

@sxa sxa commented Jan 13, 2021 •
edited
Loading

As per #2354 (review) we need to have redundancy in our infrastructure to ensure things are not tied to single systems with customer configurations. Installing the Dragonwell boot JDK8 as per the playbooks means we can build Dragonwell on all systems.

Based on the comment at #2329 (comment) it is possible that #2352 resolves the JDK11 issue, so this reverts both #2341 and #2354

Merging this will give us additional time to diagnose the alibaba current alibaba build system issues, there this hopefully fixes #2329 and adoptium/infrastructure#1832

@sxa sxa added bug Issues that are problems in the code as reported by the community windows Issues that affect or relate to the WINDOWS OS labels Jan 13, 2021
@sxa sxa added this to the January 2021 milestone Jan 13, 2021
@sxa sxa self-assigned this Jan 13, 2021
@sxa
Copy link
Member Author

sxa commented Jan 13, 2021

Looks good:

12:06:46  openjdk version "1.8.0_252-internal"
12:06:46  OpenJDK Runtime Environment (Alibaba Dragonwell 8.5.5) (build 1.8.0_252-internal-202101131151-b06)
12:06:46  OpenJDK 64-Bit Server VM (Alibaba Dragonwell 8.5.5) (build 25.252-b06, mixed mode)

12:16:00  openjdk version "11.0.9" 2020-10-20
12:16:00  OpenJDK Runtime Environment (Alibaba Dragonwell) (build 11.0.9+10)
12:16:00  OpenJDK 64-Bit Server VM (Alibaba Dragonwell) (build 11.0.9+10, mixed mode)

@M-Davies M-Davies added the dragonwell/alibaba Issues that are enhancements or bugs raised against the Dragonwell JVM of the Alibaba project label Jan 13, 2021
M-Davies
M-Davies approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@M-Davies M-Davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing that this has been tested thoroughly and appears to work, LGTM

@sxa sxa mentioned this pull request Jan 13, 2021
Closed
@sxa sxa merged commit 6da3fe8 into adoptium:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-Davies M-Davies M-Davies approved these changes

@andrew-m-leonard andrew-m-leonard andrew-m-leonard approved these changes

Assignees

@sxa sxa

Labels
bug Issues that are problems in the code as reported by the community dragonwell/alibaba Issues that are enhancements or bugs raised against the Dragonwell JVM of the Alibaba project windows Issues that affect or relate to the WINDOWS OS
Projects
None yet
Milestone
January 2021
3 participants
@sxa @M-Davies @andrew-m-leonard