Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building with GCC 10.3 for JDK18 and above on Linux (Excluding OpenJ9) #2824

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

sxa
Copy link
Member

@sxa sxa commented Jan 12, 2022

Can be implemented now that adoptium/infrastructure#2420 has been merged
Fixes #2787 (Although for now not including JDK17)

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small whitespace suggestions. Failed GH Actions will need checking as well.

@karianna
Copy link
Contributor

The GH Actions failing will still need to be addressed and the ECA check?

@sxa sxa force-pushed the gcc10.3 branch 2 times, most recently from f2b10fc to 08c720f Compare January 12, 2022 13:54
@sxa
Copy link
Member Author

sxa commented Jan 12, 2022

Failing actions were because the adoptopenjdk/centos7_build_image does not appear to have been updated with the latest playbook changes (The production centos6_build_image used on x64 builds looks ok). Having said that, I've adjusted the code so it will back off to GCC 7 instead of 4.8 when 10 does not exist, which should pass the checks, but we need to look into why we're running the checks against a docker build image we're not using, and why it's not getting the updates since it may be out of date in other ways too if it hasn't got this latest change.

@gdams any idea why the centos7 one may not have got the update from adoptium/infrastructure#2420

@sxa
Copy link
Member Author

sxa commented Jan 12, 2022

@karianna Bisheng11 seems to be broken in other PRs so that check failing is probably not a blocker
It has also been failing in the nightly builds so this is not a blocker for the PR.

@sxa sxa requested a review from karianna January 12, 2022 16:39
@gdams
Copy link
Member

gdams commented Jan 13, 2022

@gdams any idea why the centos7 one may not have got the update from adoptium/infrastructure#2420

@sxa looks like the playbook updater has been failing in Jenkins for some time: https://ci.adoptopenjdk.net/view/Infra/job/centos7_docker_image_updater/. Weirdly it seems to be failing to push (I'll do some digging)

@sxa
Copy link
Member Author

sxa commented Jan 13, 2022

@gdams any idea why the centos7 one may not have got the update from adoptium/infrastructure#2420

@sxa looks like the playbook updater has been failing in Jenkins for some time: https://ci.adoptopenjdk.net/view/Infra/job/centos7_docker_image_updater/. Weirdly it seems to be failing to push (I'll do some digging)

Let's move further discussion into adoptium/infrastructure#2432

@sxa
Copy link
Member Author

sxa commented Jan 13, 2022

I'm comfortable that this is having the desired effect - merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade jdk17+ linux builds to use gcc-8
4 participants