-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable building with GCC 10.3 for JDK18 and above on Linux (Excluding OpenJ9) #2824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small whitespace suggestions. Failed GH Actions will need checking as well.
The GH Actions failing will still need to be addressed and the ECA check? |
f2b10fc
to
08c720f
Compare
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Failing actions were because the @gdams any idea why the centos7 one may not have got the update from adoptium/infrastructure#2420 |
@karianna Bisheng11 seems to be broken in other PRs so that check failing is probably not a blocker |
@sxa looks like the playbook updater has been failing in Jenkins for some time: https://ci.adoptopenjdk.net/view/Infra/job/centos7_docker_image_updater/. Weirdly it seems to be failing to push (I'll do some digging) |
Let's move further discussion into adoptium/infrastructure#2432 |
I'm comfortable that this is having the desired effect - merging now. |
Can be implemented now that adoptium/infrastructure#2420 has been merged
Fixes #2787 (Although for now not including JDK17)