Fix: add back expand/collapse sub series in selected series page #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I missed it also. When I saw the issue get opened I was tempted to remove this feature for good since writing queries for this is going to be difficult and messy. Currently we are loading the entire series then doing the grouping but that isn't going to work well when someone has thousands of books in a series. I've been working on moving off the old data model so hopefully it gets easier to work with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3287
When I implemented #3117, I missed implementing expand/collapse subseries menu items in selected series pages (the states variables have similar and confusing names so I missed the semantic difference). This fixes it.