Don't use private class properties #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
force-pushed
the
dont-use-private-properties
branch
from
1f51911
to
822c315
Compare
davidyuk
force-pushed
the
dont-use-private-properties
branch
2 times, most recently
from
ce27dd4
to
ee1c0b9
Compare
dincho
previously approved these changes
Dec 12, 2021
davidyuk
force-pushed
the
dont-use-private-properties
branch
from
ee1c0b9
to
b7bdd53
Compare
dincho
approved these changes
Dec 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #113
is private class properties an es2022 feature? https://babeljs.io/docs/en/babel-plugin-proposal-private-property-in-object
not sure about changes in JSDoc, inspired by https://stackoverflow.com/a/51467945/6176994