-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(babel): compatibility with create-react-app #1365
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1365 +/- ##
========================================
Coverage 87.87% 87.87%
========================================
Files 55 55
Lines 3109 3109
Branches 40 40
========================================
Hits 2732 2732
Misses 356 356
Partials 21 21 Continue to review full report at Codecov.
|
7152ac6
to
4decdce
Compare
4decdce
to
5b30bb2
Compare
5b30bb2
to
04a070a
Compare
04a070a
to
a221299
Compare
@davidyuk do we need a new release of calldata-lib for this? |
We can merge this as it is now, and switch to the new calldata release before the next SDK release. Without switching to calldata's master, the compatibility issue won't be solved 🤷♀️ |
a221299
to
137cf4d
Compare
137cf4d
to
1b5db54
Compare
1b5db54
to
e882ede
Compare
tests are failing. https://github.com/aeternity/aepp-sdk-js/runs/4962960426?check_suite_focus=true#step:8:149 Crypto and Websocekt APIs are tricky. May work for React app but fails for react-native projects. |
e882ede
to
533d1a6
Compare
@davidyuk new release of calldata-lib is out: https://www.npmjs.com/package/@aeternity/aepp-calldata |
9b0f3dc
to
4ca268d
Compare
4ca268d
to
aff7084
Compare
aff7084
to
9b42b5a
Compare
9b42b5a
to
9e8f82e
Compare
closes #1364
depends on aeternity/aepp-calldata-js#114
depends on aeternity/aepp-calldata-js#122
closes #1413
found issues: dcposch/blakejs#19 swagger-api/swagger-js#2457