fix(web): use right type for icon name at core/EmptyState #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was broken when migration layout/Icon.jsx to layout/Icon.tsx in #1690
Since it has been touched in a previous commit, moves it to TypeScript although still being an unfinished component and its future is even unknown.
That was at core/EmptyState because props were not well defined when using JSDoc. Now these props are properly defined with TypeScript, such a directive is no longer necessary.
imobachgs
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Unfortunately, #1690 broken a type import at core/EmptyState component that has been cough by OBS
Solution
To use the right type (d9554b1) and take the opportunity for migrating the component to TypeScript (9719d0b) which makes possible to get rid of a
@ts-expect-errordirective (749db9e)Testing
Tested manually by running
NODE_ENV=production npm run build