Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): use right type for icon name at core/EmptyState #1711

Merged
merged 3 commits into from
Oct 29, 2024
Merged

fix(web): use right type for icon name at core/EmptyState #1711

merged 3 commits into from
Oct 29, 2024
+14 −19

Commits on Oct 29, 2024

  1. fix(web) use right type for icon name at EmptyState 

    It was broken when migration layout/Icon.jsx to layout/Icon.tsx in
#1690
    @dgdavid
    dgdavid committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d9554b1 View commit details
    Browse the repository at this point in the history

  2. refactor(web) migrate core/EptyState to TypeScript 

    Since it has been touched in a previous commit, moves it to TypeScript
although still being an unfinished component and its future is even
unknown.
    @dgdavid
    dgdavid committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    9719d0b View commit details
    Browse the repository at this point in the history

  3. fix(web): drop no longer needed @ts-expect-error 

    That was at core/EmptyState because props were not well defined when
using JSDoc. Now these props are properly defined with TypeScript, such
a directive is no longer necessary.
    @dgdavid
    dgdavid committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    749db9e View commit details
    Browse the repository at this point in the history