[web] Add simple Fieldset component #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since PF4/FormFieldGroup[1] looks a bit complex for our use cases right now, we have wrapped the native HTML fieldset/legend elements in a simple Fieldset component which also tweaks a little bit their default look&feel. [1] https://www.patternfly.org/v4/components/form/#formfieldgroup)
dgdavid
force-pushed
the
add-fieldset-component
branch
from
5f661e3
to
a33485d
Compare
dgdavid
changed the title
imobachgs
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the context of #321, we felt that the PF4/FormFieldGroup was a bit complex for our use case when grouping some form elements in the settings section of the storage page.
Solution
Thus, we've built a wrapper component for providing a simple way to use the native HTML
fieldsetandlegendelements.Testing
Screenshots
See below image of a fake language settings to get an idea how it could look.