Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage proposal UI #321

Merged
merged 42 commits into from
Dec 2, 2022
Merged

Storage proposal UI #321

merged 42 commits into from
Dec 2, 2022

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Nov 18, 2022 •
edited by dgdavid
Loading

Problem

Currently, the storage proposal allows selecting only the device to install into. But the YaST storage proposal is much more powerful and resilient. Some options like selecting LVM or encryption should be offered at installation time.

Solution

Add a new storage proposal UI. The installation summary has a link to go to a specific page for configuring the storage proposal. For now, it only offers LVM and encryption settings. This new page will be extended to configure the volumes to create.

Testing

  • Added unit tests
  • Tested manually

Note: some unit tests are missing, for example for ProposalSettingsSection and for the storage client. They will be added later because we want to generate a new ISO as soon as possible.

Screenshots

Storage overview Storage page Storage page with errors
Screenshot from 2022-12-02 12-22-37 Screenshot from 2022-12-02 12-27-10 Screenshot from 2022-12-02 12-23-22
Storage device selector Storage encryption options
Screenshot from 2022-12-02 12-22-48 Screenshot from 2022-12-02 13-38-27

@joseivanlopez joseivanlopez force-pushed the storage-proposal-ui branch 4 times, most recently from 0d17080 to 2b70b64 Compare November 24, 2022 16:47
This was referenced Nov 25, 2022
Merged
Merged
@joseivanlopez joseivanlopez force-pushed the storage-proposal-ui branch 3 times, most recently from 1e58059 to 9973234 Compare November 25, 2022 16:38
@ancorgs ancorgs mentioned this pull request Nov 30, 2022
Merged
@dgdavid dgdavid force-pushed the storage-proposal-ui branch 2 times, most recently from 8847bc7 to 21c18c8 Compare December 1, 2022 20:38
@coveralls
Copy link

coveralls commented Dec 2, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 75.386% when pulling 88334f1 on joseivanlopez:storage-proposal-ui into 5a401cd on yast:master.

@joseivanlopez joseivanlopez force-pushed the storage-proposal-ui branch 2 times, most recently from 5a46470 to 5055652 Compare December 2, 2022 12:39
dgdavid and others added 18 commits December 2, 2022 13:26
@dgdavid dgdavid marked this pull request as ready for review December 2, 2022 13:39
@joseivanlopez joseivanlopez merged commit b331fa5 into agama-project:master Dec 2, 2022
@joseivanlopez joseivanlopez mentioned this pull request Dec 5, 2022
Merged
@dgdavid dgdavid mentioned this pull request Dec 12, 2022
Merged
dgdavid added a commit that referenced this pull request Dec 30, 2022
@dgdavid
[web] Move SoftwareSection to "overview" namespace
7b02122 
Since the "overview" namespace was created for that purpuose when adding the
first section page (PR #321). I.e., components for summarizing sections
should live in that namespace.

See 3df4c30
dgdavid added a commit that referenced this pull request Jan 11, 2023
@dgdavid
[web] Move SoftwareSection to "overview" namespace
836e8a1 
Since the "overview" namespace was created for that purpuose when adding the
first section page (PR #321). I.e., components for summarizing sections
should live in that namespace.

See 3df4c30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgdavid dgdavid dgdavid left review comments

@imobachgs imobachgs imobachgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joseivanlopez @coveralls @imobachgs @dgdavid