Grid Select Improvements #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveoh
reviewed
May 14, 2018
| }); | ||
| } | ||
| }, this); | ||
| var existingOptions = Array.from(select.children).map(option => option.value); |
There was a problem hiding this comment.
This might need to be polyfilled if people are using IE at all.
There was a problem hiding this comment.
Ah, I thought that Babel would take care of this one for me. I'm not too worried about supporting IE at this point for this project.
steveoh
reviewed
May 14, 2018
| _getValueAttr() { | ||
| const inheritedValue = this.inherited(arguments); | ||
|
|
||
| return isNaN(inheritedValue) ? null : inheritedValue; |
There was a problem hiding this comment.
does this mess up the data submission or any of the local storage stuff?
There was a problem hiding this comment.
No. In fact, it fixes problems such as attempting to write a string (NaN) to numeric fields.
There was a problem hiding this comment.
Does 0 get written to the db for empty records?
steveoh
approved these changes
May 17, 2018
temporarily until gruntjs/grunt-contrib-jasmine#269 is merged Other misc test cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You'll just have to believe me that the tests are passing.