Switch from PhantomJS to Chrome Headless via Puppeteer #269

stdavis · 2018-05-17T14:22:28Z

Closes #257

This PR tears out PhantomJS (no longer maintained) and replaces it with Chrome Headless via the Puppeteer project. Our office got tired of fighting with PhamtomJS.

Here are the highlights of the changes:

Removed all references to phantomjs (not quite there yet)
Upgrade from jshint to eslint (required for the async/await code IIRC)
Cleaned up a bunch of apparently unused jasmine files
Upgraded min node version from 0.10.0 to 7.6.0 (required for async/await)

Let me and/or @steveoh know if you think that this has a chance to be merged and what we can do to make that happen.

Thanks for the great project!

- jshint -> eslint - upgrade min node version to 7.6.0 for async/await code Co-authored-by: Scott Davis <[email protected]> Co-authored-by: Steve Gourley <[email protected]>

jsf-clabot · 2018-05-17T14:22:30Z

All committers have signed the CLA.

vladikoff · 2018-05-17T14:22:59Z

.travis.yml

@@ -3,8 +3,10 @@ sudo: false
 language: node_js

 node_js:
+  - "4"


we can probably drop 4, it's EOL

We should probably drop 6 then also?

vladikoff · 2018-05-17T14:23:17Z

README.md

@@ -1,4 +1,4 @@
-# grunt-contrib-jasmine v1.1.0 [![Build Status: Linux](https://travis-ci.org/gruntjs/grunt-contrib-jasmine.svg?branch=master)](https://travis-ci.org/gruntjs/grunt-contrib-jasmine) [![Build Status: Windows](https://ci.appveyor.com/api/projects/status/5985958by5rhnh31/branch/master?svg=true)](https://ci.appveyor.com/project/gruntjs/grunt-contrib-jasmine/branch/master)
+# grunt-contrib-jasmine v1.2.0 [![Build Status: Linux](https://travis-ci.org/gruntjs/grunt-contrib-jasmine.svg?branch=master)](https://travis-ci.org/gruntjs/grunt-contrib-jasmine) [![Build Status: Windows](https://ci.appveyor.com/api/projects/status/5985958by5rhnh31/branch/master?svg=true)](https://ci.appveyor.com/project/gruntjs/grunt-contrib-jasmine/branch/master)


we can just v2 this probably due to major change?

It is a major change but it doesn’t break the current api.

I'll revert this and let the versioning get handled by the merging folks.

vladikoff · 2018-05-17T14:23:24Z

appveyor.yml

@@ -5,12 +5,16 @@ version: "{build}"
 # What combinations to test
 environment:
  matrix:
-    - nodejs_version: "6"
+    - nodejs_version: "4"


same, drop 4

vladikoff · 2018-05-17T14:23:37Z

package.json

@@ -9,25 +9,25 @@
  "repository": "gruntjs/grunt-contrib-jasmine",
  "license": "MIT",
  "engines": {
-    "node": ">=0.10.0"
+    "node": ">=7.6.0"


needs to be >=6 , possible?

Wellll......

Caution: Puppeteer requires at least Node v6.4.0, but the examples below use async/await which is only supported in Node v7.6.0 or greater.

Ah I see what happened, the ci files were auto generated from internal. So by adding this we would probably say that this supports node >=8 only

vladikoff · 2018-05-17T14:24:36Z

tasks/jasmine.js

+
+    await page.exposeFunction('jasmine.done_fail', function(url) {
+      grunt.log.error();
+      grunt.warn('PhantomJS unable to load "' + url + '" URI.', 90);


this still says phantomjs?

temporarily until gruntjs/grunt-contrib-jasmine#269 is merged Other misc test cleanup

steveoh · 2018-05-17T15:46:29Z

@vladikoff do you have any ideas for the The http2 module is an experimental API? It's failing in the current v8 master branch for the same reason.

* Remove NaN values form number fields in grids Closes #119 * Fix [other] option bug in grid selects Related to #75 * Prevent entering an existing option in the "Other" dialog Closes #75 * switch to agrc/grunt-contrib-jasmine temporarily until gruntjs/grunt-contrib-jasmine#269 is merged Other misc test cleanup * Upgrade permissions on travis to help with Chrome Headless travis-ci/travis-ci#8836 * fix tests

stdavis · 2018-05-17T22:41:26Z

I was able to get the travis build running for our fork's repo: https://travis-ci.org/agrc/grunt-contrib-jasmine

I can't think of anything that would be different other than the cache. Perhaps you want to manually clear the cache in travis for this project?

As for the AppVeyor failure, it may be related to this: gruntjs/grunt-contrib-connect#235. Not sure if you want to add the environment variable workaround or something different.

steveoh · 2018-05-18T00:13:33Z

Yeah, @vladikoff maybe try deleting the build caches

stdavis · 2018-05-18T13:42:39Z

I think that I have all referenced to PhantomJS replaced with Headless Chrome.

stdavis and others added 8 commits May 17, 2018 08:09

Initial Puppeteer Implementation

f78c60e

- jshint -> eslint - upgrade min node version to 7.6.0 for async/await code Co-authored-by: Scott Davis <[email protected]> Co-authored-by: Steve Gourley <[email protected]>

add more logs and await the page close

12c60bd

clean up debugger statement

dbb62e0

ignore .custom folder

9ce854d

downgrade to jasmine 2.5.2

b4969f2

don't fail tests on JS page errors

cf768ef

removed unused jasmine library

4c93d0d

remove temp task

b30958b

vladikoff reviewed May 17, 2018

View reviewed changes

stdavis added a commit to agrc/electrofishing that referenced this pull request May 17, 2018

switch to agrc/grunt-contrib-jasmine

8de25c0

temporarily until gruntjs/grunt-contrib-jasmine#269 is merged Other misc test cleanup

steveoh added 6 commits May 17, 2018 09:13

drop node 4

ddfb86c

changes for travis

9f3cfbb

require node 8?

af9675b

remove phantom text

8209e9b

roll versions forward

1029d39

revert versioning

0b0a405

remove chrome travis add on

65683f0

stdavis force-pushed the master branch from 5fbb70c to 7e387c3 Compare May 18, 2018 13:42

stdavis added 2 commits May 18, 2018 07:44

remove irrelevant test

8dfa262

Finish replacing all references to PhantomJS with Headless Chrome

5d1adb9

stdavis force-pushed the master branch from 7e387c3 to 5d1adb9 Compare May 18, 2018 13:44

vladikoff merged commit 02e72f3 into gruntjs:master May 20, 2018

jgravois mentioned this pull request Jun 6, 2018

phantomjs > headless chrome Esri/terraformer-arcgis-parser#51

Closed

chicoxyzzy mentioned this pull request Nov 14, 2018

PhantomJS development is now suspended compat-table/compat-table#1364

Merged

jywarren mentioned this pull request Jan 2, 2019

Make Fisheye-gl module compatible with nodejs publiclab/image-sequencer#542

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch from PhantomJS to Chrome Headless via Puppeteer #269

Switch from PhantomJS to Chrome Headless via Puppeteer #269

stdavis commented May 17, 2018 •

edited

Loading

jsf-clabot commented May 17, 2018 •

edited

Loading

vladikoff May 17, 2018

steveoh May 17, 2018

steveoh May 17, 2018

vladikoff May 17, 2018

steveoh May 17, 2018

steveoh May 17, 2018

vladikoff May 17, 2018

vladikoff May 17, 2018

steveoh May 17, 2018

vladikoff May 17, 2018

steveoh May 17, 2018

vladikoff May 17, 2018

steveoh May 17, 2018

steveoh commented May 17, 2018

stdavis commented May 17, 2018

steveoh commented May 18, 2018

stdavis commented May 18, 2018

		@@ -1,4 +1,4 @@
		# grunt-contrib-jasmine v1.1.0 [![Build Status: Linux](https://travis-ci.org/gruntjs/grunt-contrib-jasmine.svg?branch=master)](https://travis-ci.org/gruntjs/grunt-contrib-jasmine) [![Build Status: Windows](https://ci.appveyor.com/api/projects/status/5985958by5rhnh31/branch/master?svg=true)](https://ci.appveyor.com/project/gruntjs/grunt-contrib-jasmine/branch/master)
		# grunt-contrib-jasmine v1.2.0 [![Build Status: Linux](https://travis-ci.org/gruntjs/grunt-contrib-jasmine.svg?branch=master)](https://travis-ci.org/gruntjs/grunt-contrib-jasmine) [![Build Status: Windows](https://ci.appveyor.com/api/projects/status/5985958by5rhnh31/branch/master?svg=true)](https://ci.appveyor.com/project/gruntjs/grunt-contrib-jasmine/branch/master)

Switch from PhantomJS to Chrome Headless via Puppeteer #269

Switch from PhantomJS to Chrome Headless via Puppeteer #269

Conversation

stdavis commented May 17, 2018 • edited Loading

jsf-clabot commented May 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steveoh commented May 17, 2018

stdavis commented May 17, 2018

steveoh commented May 18, 2018

stdavis commented May 18, 2018

stdavis commented May 17, 2018 •

edited

Loading

jsf-clabot commented May 17, 2018 •

edited

Loading