Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search test done is inconsistent as it test deprecated or multilingual classes that are not indexed #223

Closed
Tracked by #279
jonquet opened this issue Feb 18, 2022 · 4 comments
Assignees
Labels
bug content Issues related to the content of AgroPortal

Comments

@jonquet
Copy link
Contributor

jonquet commented Feb 18, 2022

We can assume the Search test done by the diagnostic script is inconsistent as it tests on classes that are not indexed such as deprecated ones or classes with label in another language.

In AgroPortal, check out DSW report :
image

The 3 concepts tested in red are declared deprecated in the source file.

@jonquet
Copy link
Contributor Author

jonquet commented Feb 18, 2022

Same situation occur with classes for which there is only a label tagged with another language tag than english. They are used for test but are not indexed.
For instance ASCOPAIN-T in AgroPortal

image

@jonquet
Copy link
Contributor Author

jonquet commented Feb 18, 2022

@mdorf @jvendetti @graybeal for information

@syphax-bouazzouni syphax-bouazzouni added the content Issues related to the content of AgroPortal label Feb 24, 2022
@syphax-bouazzouni
Copy link
Contributor

syphax-bouazzouni commented Feb 25, 2022

Multilingual classes indexation

After more investigation in the case of multilingual classes, prefLabel are not indexed
And they are not indexed because this function that fetch the prefLabel attribute (and others) from the store return an empty array in the case of multilingual class.
We can verify this in CSV files (that contains the same attributes that are indexed) :

  • For the case of an english class (e.g ATC), we see that the column prefLabel is filled
    image
  • While for the case of a french class (e.g ASCOPAIN-T) , we see that column prefLabel (and some others) is(are) empty
    image

Where does the bug come from

I think that it's related to changes made by Vincent in implementing a multilingual portal (for sifrbioportal) (see compare)
image

To do

Fix the function self.map_attributes

Deprecated classes indexation

#222

@syphax-bouazzouni
Copy link
Contributor

fixed by ontoportal-lirmm/goo#6 and ontoportal-lirmm/goo#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug content Issues related to the content of AgroPortal
Projects
None yet
Development

No branches or pull requests

2 participants