forked from ontoportal/goo
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add portal languages preference #118
Closed
syphax-bouazzouni
wants to merge
11
commits into
ncbo:develop
from
ontoportal-lirmm:pl/add-mainlang-defaults-refactored
Closed
Feature: Add portal languages preference #118
syphax-bouazzouni
wants to merge
11
commits into
ncbo:develop
from
ontoportal-lirmm:pl/add-mainlang-defaults-refactored
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 tasks
6 tasks
syphax-bouazzouni
force-pushed
the
pl/add-mainlang-defaults-refactored
branch
from
November 25, 2022 13:15
8c84c9e
to
34a9fdf
Compare
syphax-bouazzouni
changed the title
Add portal languages preference
Feature: Add portal languages preference
Jan 19, 2023
This was referenced Jan 20, 2023
@mdorf please review this PR, we should merge it next |
Merge develop to master, release v5.29.0
replace with #150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend on PL
Goal
Define a preference list of languages to choose to print/show in the portal.
So if we set the languages configuration variable like so
@@main_languages = ["en", "fr"]
, the API will show only English values and values with no language tags.And secondly, if no English or language-tagged values found we print french values.
Else print all the values.
Agroportal and SIFRportal use case
@@main_languages = ["fr"]
)Related issues