Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add portal languages preference #118

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Mar 17, 2022

Depend on PL

Goal

Define a preference list of languages to choose to print/show in the portal.

So if we set the languages configuration variable like so @@main_languages = ["en", "fr"], the API will show only English values and values with no language tags.
And secondly, if no English or language-tagged values found we print french values.
Else print all the values.

Agroportal and SIFRportal use case

  1. At SIFRportal we use this feature to give priority to French values ( using this configuration: @@main_languages = ["fr"] )
  2. At Agrportal we choose to have french as a secondary language ( with the fact that in most cases our ontologies are in English or French), so we have set the main_languages to ["en", "fr"] so that if at Agroportal we have an ontology that is only in French, Spanish and German we will print French values.

Related issues

@syphax-bouazzouni syphax-bouazzouni force-pushed the pl/add-mainlang-defaults-refactored branch from 8c84c9e to 34a9fdf Compare November 25, 2022 13:15
@syphax-bouazzouni syphax-bouazzouni changed the title Add portal languages preference Feature: Add portal languages preference Jan 19, 2023
@alexskr alexskr requested a review from mdorf March 14, 2024 21:54
@alexskr
Copy link
Member

alexskr commented Mar 14, 2024

@mdorf please review this PR, we should merge it next

Merge develop to master,  release v5.29.0
@alexskr alexskr changed the base branch from master to develop March 21, 2024 16:43
@syphax-bouazzouni syphax-bouazzouni marked this pull request as draft April 17, 2024 14:49
@syphax-bouazzouni
Copy link
Author

replace with #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants