Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable two Linux tests #327

Closed
wants to merge 2 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented May 22, 2024

Fixes #321


      - if: runner.os == 'Linux'
        run: sudo apt-get install -y libmagic1

sudo apt-get install -y libmagic1
Reading package lists...
Building dependency tree...
Reading state information...
libmagic1 is already the newest version (1:5.41-3ubuntu0.1).
libmagic1 set to manually installed.
0 upgraded, 0 newly installed, 0 to remove and 15 not upgraded.

@ddelange Your review, please.

@ddelange
Copy link
Contributor

ddelange commented May 22, 2024

libmagic1 is already the newest version (1:5.41-3ubuntu0.1).

I think you'll need 5.44 or newer. At least with 5.45 it's passing: https://github.com/ddelange/python-magic/actions/runs/9189333058/job/25271162839#step:4:13

To install latest libmagic from source, I'm adding add_libmagic.sh in #294.

@cclauss
Copy link
Contributor Author

cclauss commented May 22, 2024

Closing in favor of #294 which fixes these tests.

@cclauss cclauss closed this May 22, 2024
@cclauss cclauss deleted the re-enable-two-Linux-tests branch May 22, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix two failing tests on Linux
2 participants