Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable two Linux tests #327

Closed
wants to merge 2 commits into from
Closed

Re-enable two Linux tests #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d32554d
Re-enable two Linux tests
cclauss May 22, 2024
801d9ba
- if: runner.os == 'Linux' run: sudo apt-get install -y libmagic1
cclauss May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ jobs:
- run: pip install --upgrade pip
- run: pip install --upgrade pytest
- run: pip install --editable .
- if: runner.os == 'Linux'
run: sudo apt-get install -y libmagic1
- if: runner.os == 'macOS'
run: brew install libmagic
- if: runner.os == 'Windows'
Expand Down
4 changes: 0 additions & 4 deletions test/python_magic_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,6 @@ def test_mime_types(self):
finally:
os.unlink(dest)

# TODO: Fix this failing test on Ubuntu
@pytest.mark.skipif(sys.platform == "linux", reason="'JSON data' not found")
def test_descriptions(self):
m = magic.Magic()
os.environ["TZ"] = "UTC" # To get last modified date of test.gz in UTC
Expand Down Expand Up @@ -161,8 +159,6 @@ def test_descriptions(self):
finally:
del os.environ["TZ"]

# TODO: Fix this failing test on Ubuntu
@pytest.mark.skipif(sys.platform == "linux", reason="'JSON data' not found")
def test_descriptions_no_soft(self):
m = magic.Magic(check_soft=False)
self.assert_values(
Expand Down
Loading