Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default value for cooldown time incorrectly shown in the default interactive prompt #3634

Closed
giovannipizzi opened this issue Dec 10, 2019 · 0 comments · Fixed by #3636
Closed

Default value for cooldown time incorrectly shown in the default interactive prompt #3634

giovannipizzi opened this issue Dec 10, 2019 · 0 comments · Fixed by #3636
Assignees
@giovannipizzi
Labels
topic/transports type/bug
Milestone
v1.1.0

Comments

@giovannipizzi
Copy link
Member

The value that is shown when reconfiguring a computer is always the class default rather than the value set in the authinfo. So that reconfiguring a computer and just pressing enter would reset the default value.
The current value should be instead be shown.
@giovannipizzi giovannipizzi added this to the v1.1.0 milestone Dec 10, 2019
@giovannipizzi giovannipizzi self-assigned this Dec 10, 2019
@giovannipizzi giovannipizzi mentioned this issue Dec 10, 2019
Merged
giovannipizzi added a commit to giovannipizzi/aiida-core that referenced this issue Dec 12, 2019
@giovannipizzi
Fix two issues in verdi computer configure ssh
2e4d07c 
The interactive SSH was not accepting an empty
ssh key_filename, while this should be acceptable.
I am also adding a test for the interactive setup of
SSH computers.

Moreover, when reconfiguring a computer, the value
of the cooldown time wasn't resued from the authinfo;
instead, the class default was also reused due to some
hardcoding. Code now behaves correctly and is simplified
avoid duplication in base classes and subclasses.

Fixes aiidateam#3633 and fixes aiidateam#3634
sphuber pushed a commit that referenced this issue Dec 12, 2019
@giovannipizzi @sphuber
Fix two issues in verdi computer configure ssh
2eac63e 
The interactive SSH was not accepting an empty
ssh key_filename, while this should be acceptable.
I am also adding a test for the interactive setup of
SSH computers.

Moreover, when reconfiguring a computer, the value
of the cooldown time wasn't resued from the authinfo;
instead, the class default was also reused due to some
hardcoding. Code now behaves correctly and is simplified
avoid duplication in base classes and subclasses.

Fixes #3633 and fixes #3634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giovannipizzi giovannipizzi

Labels
topic/transports type/bug
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Fix two issues in verdi computer configure ssh giovannipizzi/aiida-core
1 participant
@giovannipizzi