Fix two issues in verdi computer configure ssh
#3636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note for reviewers: there are two commits - the first one does the job, the second is just fixing issues in pylint, so you might want to check them independently. Note for @yakutovicha who's working on #2207: I'm removing two more files (actually two complex ones) from the pylint exclude list. |
sphuber
requested changes
Dec 12, 2019
The interactive SSH was not accepting an empty ssh key_filename, while this should be acceptable. I am also adding a test for the interactive setup of SSH computers. Moreover, when reconfiguring a computer, the value of the cooldown time wasn't resued from the authinfo; instead, the class default was also reused due to some hardcoding. Code now behaves correctly and is simplified avoid duplication in base classes and subclasses. Fixes aiidateam#3633 and fixes aiidateam#3634
giovannipizzi
force-pushed
the
fix_3633_3634_transport_issues
branch
from
55ee27a
to
6068547
Compare
|
Fixed the two comments by @sphuber in the first of the two commits, then rebased all on top of the most recent develop and force-pushed. This is now ready for (re)review. |
sphuber
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interactive SSH was not accepting an empty
ssh key_filename, while this should be acceptable.
I am also adding a test for the interactive setup of
SSH computers.
Moreover, when reconfiguring a computer, the value
of the cooldown time wasn't resued from the authinfo;
instead, the class default was also reused due to some
hardcoding. Code now behaves correctly and is simplified
avoid duplication in base classes and subclasses.
Fixes #3633 and fixes #3634