Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: drop support for Python 3.7 #5307

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Jan 13, 2022

Fixes #5306

Following AEP 003, which follows NEP 029, support for Python 3.7 is
dropped as of December 26 2021.

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #5307 (47db0be) into develop (afebb6e) will increase coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5307      +/-   ##
===========================================
+ Coverage    81.51%   81.90%   +0.39%     
===========================================
  Files          530      530              
  Lines        37105    38009     +904     
===========================================
+ Hits         30242    31127     +885     
- Misses        6863     6882      +19     
Flag Coverage Δ
django 77.47% <ø> (+0.50%) ⬆️
sqlalchemy 76.21% <ø> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/tools/archive/implementations/sqlite/main.py 87.18% <0.00%> (-5.12%) ⬇️
aiida/orm/implementation/querybuilder.py 90.20% <0.00%> (-3.92%) ⬇️
aiida/orm/nodes/data/jsonable.py 95.32% <0.00%> (-3.12%) ⬇️
aiida/orm/implementation/groups.py 77.03% <0.00%> (-2.70%) ⬇️
aiida/common/lang.py 78.58% <0.00%> (-1.91%) ⬇️
aiida/tools/archive/abstract.py 85.15% <0.00%> (-1.85%) ⬇️
...ida/tools/archive/implementations/sqlite/writer.py 89.51% <0.00%> (-1.10%) ⬇️
...m/implementation/sqlalchemy/querybuilder/joiner.py 90.22% <0.00%> (-1.08%) ⬇️
aiida/orm/entities.py 95.74% <0.00%> (-0.93%) ⬇️
aiida/tools/archive/imports.py 91.33% <0.00%> (-0.39%) ⬇️
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afebb6e...47db0be. Read the comment docs.

@sphuber sphuber requested a review from csadorf January 13, 2022 12:39
@csadorf
Copy link
Contributor

csadorf commented Jan 13, 2022

@sphuber Was it already investigated why the test-install:tests are now failing?

Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me however the tests are failing.

@sphuber
Copy link
Contributor Author

sphuber commented Jan 13, 2022

I was looking into it, and it doesn't seem to have anything to do with this PR because #5303 is failing for the same reasons. I have no idea yet why this should be failing now.

@sphuber
Copy link
Contributor Author

sphuber commented Jan 13, 2022

It looks like pytest-asyncio==0.17.0 is now getting installed instead of pytest-asyncio==0.16.0, so it seems likely it has to do with this. Will try to pin and see if that fixes it.

@sphuber
Copy link
Contributor Author

sphuber commented Jan 13, 2022

pytest-asyncio v0.17 was released 3 hours ago ... https://pypi.org/project/pytest-asyncio/

@csadorf
Copy link
Contributor

csadorf commented Jan 13, 2022

pytest-asyncio v0.17 was released 3 hours ago ... https://pypi.org/project/pytest-asyncio/

dependecy hell

@sphuber
Copy link
Contributor Author

sphuber commented Jan 13, 2022

@csadorf added temporary fix in #5309 . Opened issue #5310 for a more long term solution as it is not immediately obvious how to solve this for all versions

@sphuber sphuber force-pushed the fix/5306/drop-support-python-3.7 branch from 6db3628 to 732b3e5 Compare January 13, 2022 15:21
Following AEP 003, which follows NEP 029, support for Python 3.7 is
dropped as of December 26 2021.
@sphuber sphuber force-pushed the fix/5306/drop-support-python-3.7 branch from 732b3e5 to 47db0be Compare January 13, 2022 15:22
@sphuber sphuber requested a review from csadorf January 13, 2022 15:22
@sphuber sphuber merged commit 401da47 into aiidateam:develop Jan 13, 2022
@sphuber sphuber deleted the fix/5306/drop-support-python-3.7 branch January 14, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.7
2 participants