Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: add upper limit for pytest-asyncio #5309

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Jan 13, 2022

The just released version v0.17 of pytest-asyncio causes the async
tests in tests/engine/test_utils.py to fail. For now we are putting an
upper limit on the requirement until a proper solution is found.

The just released version v0.17 of `pytest-asyncio` causes the async
tests in `tests/engine/test_utils.py` to fail. For now we are putting an
upper limit on the requirement until a proper solution is found.
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #5309 (5a0fa5a) into develop (ea8a988) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5309   +/-   ##
========================================
  Coverage    81.51%   81.51%           
========================================
  Files          530      530           
  Lines        37105    37105           
========================================
  Hits         30242    30242           
  Misses        6863     6863           
Flag Coverage Δ
django 76.97% <ø> (ø)
sqlalchemy 75.97% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea8a988...5a0fa5a. Read the comment docs.

Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our tests dependencies could actually be pinned.

@sphuber sphuber merged commit afebb6e into aiidateam:develop Jan 13, 2022
@sphuber sphuber deleted the fix/upper-limit-pytest-asyncio branch January 13, 2022 15:19
sphuber added a commit that referenced this pull request Mar 7, 2022
The just released version v0.17 of `pytest-asyncio` causes the async
tests in `tests/engine/test_utils.py` to fail. For now we are putting an
upper limit on the requirement until a proper solution is found.

Cherry-pick: afebb6e
sphuber added a commit that referenced this pull request Mar 7, 2022
The just released version v0.17 of `pytest-asyncio` causes the async
tests in `tests/engine/test_utils.py` to fail. For now we are putting an
upper limit on the requirement until a proper solution is found.

Cherry-pick: afebb6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants