-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using the cgi module, deprecated in Python 3.11 per PEP 594 #6708
Conversation
Untested and mostly for discussion purposes for now, quite likely some refinements would be in order. |
Codecov Report
@@ Coverage Diff @@
## master #6708 +/- ##
=======================================
Coverage 93.36% 93.36%
=======================================
Files 104 104
Lines 30628 30631 +3
Branches 3077 3077
=======================================
+ Hits 28596 28599 +3
Misses 1859 1859
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Sam Bull <[email protected]>
Backport to 3.9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply a045480 on top of patchback/backports/3.9/a0454809e3fd15f70c95d794addf005d9bd95b23/pr-6708 Backporting merged PR #6708 into master
🤖 @patchback |
If you could also handle the backport, that would be great. |
…-libs#6708) * Stop using the cgi module, deprecated in Python 3.11 per PEP 594 https://peps.python.org/pep-0594/#cgi * Simplify creating params dict Co-authored-by: Sam Bull <[email protected]> * Create 6708.misc Co-authored-by: Sam Bull <[email protected]> (cherry picked from commit a045480)
…-libs#6708) * Stop using the cgi module, deprecated in Python 3.11 per PEP 594 https://peps.python.org/pep-0594/#cgi * Simplify creating params dict Co-authored-by: Sam Bull <[email protected]> * Create 6708.misc Co-authored-by: Sam Bull <[email protected]> (cherry picked from commit a045480)
…) (#6734) * Stop using the cgi module, deprecated in Python 3.11 per PEP 594 https://peps.python.org/pep-0594/#cgi * Simplify creating params dict Co-authored-by: Sam Bull <[email protected]> * Create 6708.misc Co-authored-by: Sam Bull <[email protected]> (cherry picked from commit a045480)
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply a045480 on top of patchback/backports/3.8/a0454809e3fd15f70c95d794addf005d9bd95b23/pr-6708 Backporting merged PR #6708 into master
🤖 @patchback |
…) (#6734) * Stop using the cgi module, deprecated in Python 3.11 per PEP 594 https://peps.python.org/pep-0594/#cgi * Simplify creating params dict Co-authored-by: Sam Bull <[email protected]> * Create 6708.misc Co-authored-by: Sam Bull <[email protected]> (cherry picked from commit a045480)
Backported to 3.8 as cb79f0d |
What do these changes do?
Removes use of the
cgi
module which is deprecated in 3.11+ per https://peps.python.org/pep-0594/#cgiAre there changes in behavior for the user?
No
Related issue number
No
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.