Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport][3.9] Stop using the cgi module, deprecated in Python 3.11 per PEP 594 #6734

Merged
merged 1 commit into from
May 6, 2022

Conversation

scop
Copy link
Contributor

@scop scop commented May 5, 2022

What do these changes do?

3.9 backport of #6708 per #6708 (comment)

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@scop scop requested a review from asvetlov as a code owner May 5, 2022 18:04
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 5, 2022
@scop scop changed the title Stop using the cgi module, deprecated in Python 3.11 per PEP 594 (#6708) Stop using the cgi module, deprecated in Python 3.11 per PEP 594 May 5, 2022
@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 5, 2022

This pull request introduces 1 alert when merging c82bc1c into 81130a5 - view on LGTM.com

new alerts:

  • 1 for Unused import

…-libs#6708)

* Stop using the cgi module, deprecated in Python 3.11 per PEP 594

https://peps.python.org/pep-0594/#cgi

* Simplify creating params dict

Co-authored-by: Sam Bull <[email protected]>

* Create 6708.misc

Co-authored-by: Sam Bull <[email protected]>
(cherry picked from commit a045480)
@Dreamsorcerer
Copy link
Member

Thanks

@Dreamsorcerer Dreamsorcerer merged commit 4ab3584 into aio-libs:3.9 May 6, 2022
@scop scop deleted the 3.9 branch May 6, 2022 20:05
@webknjaz webknjaz changed the title Stop using the cgi module, deprecated in Python 3.11 per PEP 594 [backport][3.9] Stop using the cgi module, deprecated in Python 3.11 per PEP 594 Sep 10, 2022
webknjaz pushed a commit that referenced this pull request Sep 11, 2022
…) (#6734)

* Stop using the cgi module, deprecated in Python 3.11 per PEP 594

https://peps.python.org/pep-0594/#cgi

* Simplify creating params dict

Co-authored-by: Sam Bull <[email protected]>

* Create 6708.misc

Co-authored-by: Sam Bull <[email protected]>
(cherry picked from commit a045480)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants