Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cibuild wheel setup is broken #837

Closed
hoodmane opened this issue Apr 24, 2023 · 3 comments · Fixed by #915
Closed

Cibuild wheel setup is broken #837

hoodmane opened this issue Apr 24, 2023 · 3 comments · Fixed by #915
Assignees
@webknjaz

Comments

@hoodmane
Copy link
Contributor

hoodmane commented Apr 24, 2023 •
edited
Loading

Long story short

@henryiii and I were investigating your cibuildwheel setup and there appear to be two problems with it:

  1. The wheel that is tested is different than the wheel that is placed in the wheelhouse Fix cibuildwheel test-requires #827.
  2. In CI, the import here: https://github.com/aio-libs/multidict/blob/master/multidict/_compat.py#L12 fails due to a circular import and so USE_EXTENSIONS is set to false, so tests are skipped due to "No extensions available".

When you have time, @henryiii or I would be happy to submit a patch to fix the USE_EXTENSIONS problem.
@webknjaz webknjaz self-assigned this Dec 17, 2023
@webknjaz
Copy link
Member

Thank you! I'll try to fix the second problem while remaking the packaging setup.

webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 10, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
4ee16cd 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
@webknjaz webknjaz mentioned this issue Jan 10, 2024
Merged
3 tasks
@webknjaz
Copy link
Member

The second point is going to be addressed by #915

webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 11, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
2c773f0 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 11, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
6fa392d 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 11, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
09a6cda 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 11, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
2e17d24 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 11, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
5c94793 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 12, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
5239e65 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 12, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
9e6297d 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 12, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
4f58a19 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 12, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
f5989b3 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 12, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
ee80b0c 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 12, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
76180f4 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 12, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
37ced54 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 12, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
aeec716 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 12, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
aa8c76d 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 12, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
fa62492 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 12, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
5052cd8 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 12, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
79849fd 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 13, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
68f7e5f 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 13, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
868e160 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 13, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
417f0e0 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 13, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
b0c5b45 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
webknjaz added a commit to webknjaz/multidict that referenced this issue Jan 13, 2024
@webknjaz
🧪 Rewire pytest fixtures avoiding import loops
7451dce 
This patch also refactors and reduces the duplication of the previously
existing fixtures for retrieving different multidict module
implementations and makes the c-extension testing controllable by a CLI
option on the pytest level.

Fixes aio-libs#837
@hoodmane
Copy link
Contributor Author

Thanks @webknjaz!

@webknjaz webknjaz mentioned this issue Jan 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webknjaz webknjaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🧪 Rewire pytest fixtures avoiding import loops webknjaz/multidict
2 participants
@webknjaz @hoodmane