Fix cibuildwheel test-requires #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requirements-ci includes `-e .` which rebuilts multidict and installs this version. As a result cibuildwheel ends up not testing the wheel it built, instead testing a separate wheel built by `pip install -e .` cibuildwheel automatically installs the multidict wheel, so we should only install test-requires not multidict itself.
webknjaz
force-pushed
the
cibuildwheel-test-requirements
branch
from
ce1e9f4
to
00d1f28
Compare
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #827 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 5 5
Lines 504 504
=======================================
Hits 472 472
Misses 32 32 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requirements-ci includes
-e .which rebuilts multidict and installs this version. As a result cibuildwheel ends up not testing the wheel it built, instead testing a separate wheel built bypip install -e .cibuildwheel automatically installs the multidict wheel, so we should only install test-requires not multidict itself.