-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File "yarl/_quoting.pyx", line 192, in yarl._quoting._Quoter.__init__ #485
Comments
Full trace:
Packages:
Python 3.6 |
I have the same issue above, with the same trace back. Using previous yarl==1.4.2 solves this issue. I am running this in conjunction with Discord.py, on a Raspberry Pi 2. |
Same issue using discord.py
Python 3.6 on Ubuntu 18.04.4 LTS on Windows Subsystem for Linux (WSL) |
I'm getting the same issue with aiohttp
|
See this SO answer. |
I'm also unable to reproduce this in a docker container. Do you have any consistent repro steps? I've tried installing pip |
@nihaals, I upgraded pip and I still get the problem.
I don't get the problem if I downgrade to 1.4.2. If you want more info, just give me the commands to run. |
You should backup and maybe post a tar of your yarl site-packages folder to help repro before you do this |
Fixed as follows:
Original contents of
Correct contents of
(Updated: I originally posted the same listing twice.) Let me know if you want more information. |
Could you post a tar with the original broken files? Also, your message seems to show the same output |
Sorry, copy and paste error. The following are the correct contents:
Will create the requested archive immediately. |
CC @Harmon758 |
http://www.adaelis.com/misc/temp/yarl_issue_485.tar.gz @nihaals (Update: Removed. See following message.) |
yarl_issue_485.tar.gz |
Ah, did not know I could do that. I'll remove it from my server. |
Did you update your pip after updating to 1.5.0 or before? |
Have you tried wiping the pip cache? |
I was rebuilding containers and packages were downloading and building from scratch. Container is based on alpine-3.6 image. |
rm -rf ~/.cache/pip |
Ah, I see what's happening here: $ wget https://github.com/aio-libs/yarl/releases/download/v1.5.0/yarl-1.5.0-cp36-cp36m-manylinux1_x86_64.whl
[...]
Saving to: ‘yarl-1.5.0-cp36-cp36m-manylinux1_x86_64.whl’
yarl-1.5.0-cp36-cp3 100%[=================>] 251.50K 565KB/s in 0.4s
2020-07-31 12:38:08 (565 KB/s) - ‘yarl-1.5.0-cp36-cp36m-manylinux1_x86_64.whl’ saved [257534/257534]
$ wheel unpack yarl-1.5.0-cp36-cp36m-manylinux1_x86_64.whl
Unpacking to: ./yarl-1.5.0...OK
$ ls -l yarl-1.5.0/yarl/
total 1.1M
-rw-r--r-- 1 wk wk 154 Jul 31 12:38 __init__.py
-rw-r--r-- 1 wk wk 3.5K Jul 31 12:38 __init__.pyi
-rw-r--r-- 1 wk wk 13 Jul 31 12:38 py.typed
-rw-r--r-- 1 wk wk 466K Jul 31 12:38 _quoting_c.c
-rw-r--r-- 1 wk wk 558K Jul 31 12:38 _quoting_c.cpython-36m-x86_64-linux-gnu.so
-rw-r--r-- 1 wk wk 447 Jul 31 12:38 _quoting_c.pyi
-rw-r--r-- 1 wk wk 12K Jul 31 12:38 _quoting_c.pyx
-rw-r--r-- 1 wk wk 519 Jul 31 12:38 _quoting.py
-rw-r--r-- 1 wk wk 6.4K Jul 31 12:38 _quoting_py.py
-rw-r--r-- 1 wk wk 34K Jul 31 12:38 _url.py There's just one C-extension shared object being shipped in pre-compiled platform-specific wheel. Oh, and we'll need to mark 1.5.0 as "yanked" on PyPI after the release. |
Sorry, guys. |
@asvetlov feel free to tag me for review, I think you need to also update https://github.com/aio-libs/yarl/blob/88559d4/.gitignore#L95-L96 and drop that Cython-generated C-file from the repo. |
@asvetlov When will you be doing a release? Seems like a pretty urgent hotfix |
Just now |
@asvetlov this suggests that there may still be some problems aio-libs/aiohttp#4880 (comment). @nihaals could you confirm that this has been fixed for you? |
The issue is an out of date pip version when installing (every report I've seen has used |
@kirknorthrop do you have a MWE dockerfile that can repro this? |
OK, so I've tried to replicate this this morning, and I found that if I rebuilt our base docker image (which installs some build tools like gcc, and a set of base requirements) then it is no longer present. The base requirements are all fixed to version, but not all subrequirements are - I've included at the bottom a list of ones that had changed between the two images. Our base docker image is based on We then take the base image, immediately upgrade pip (which in the failing version took us from Therefore I'm not very sure at all where the issue came from here, although it does appear to be some sort of failure in upgrading. I can't release the docker image unfortunately as it has a password embedded in it, but I am happy to help trace this as best as I can, and if I can try anything out to help then I will do so. I have a dockerfile which does the bare minimum and uses all the correct versions, but unfortunately still does not replicate! I can assure you that I'm very annoyed - I don't usually file reports unless there is good reason and I'm fairly sure it's not an issue at my end! Packages upgraded in the newer docker image: |
Talking about the very first bug report (and the following
The problem is: neither GitHub nor I have no idea how did you get it honestly. |
It's all very odd. Sorry for a false report - I'm not sure how it has happened either, given I've spent two hours now failing to replicate it! |
No problem! |
I think the file could be there due to an out of date pip version which for some reason either left the file there when updating or it somehow found it and tried adding it. Maybe someone more familiar with pip bug reports would know? Has anyone with pip 9.0.1 and yarl 1.5.0 updated to 1.5.1 and still had the issue? If updating solved it in this weird case I guess it's fixed, otherwise, may need to get some more insight from someone working on pip and maybe give a notice that anyone who has this issue should uninstall, delete all site-packages folders related to yarl, update pip then install yarl again (hopefully it doesn't come to that) |
Here's a dockerfile which seems to do all that, and even includes the exact base docker image we had the issue with... but which still doesn't exhibit that behaviour. (And we were on pip 20.1) The
|
Hello. Just want to say I got this error today after updating discord.py to 1.4.1 with yarl 1.5.0 and 1.5.1. I was able to fix it by downloading yarl 1.4.2. |
@DziQus it'd be great if you could come up with some stable reproducer |
This is late, but since there's still some discord.py users encountering this issue: Since it's possible that force reinstalling v1.5.0 even without using the cache can fail, I think it's plausible that this is because there are files that are mistakenly no longer associated with the library by pip that will not be uninstalled during the reinstall. This means that it's also possible that upgrading from v1.5.0 to v1.5.1 will not fix the issue (see also aio-libs/aiohttp#4880 (comment)), since those files will not be uninstalled during the upgrade process either. Since yarl v1.4.2's MANIFEST.in is correct, downgrading to v1.4.2 fixes the issue. |
@Harmon758 I'm pretty sure pip tracks the files correctly unless they are installed with unsupported and discouraged methods like |
Even if the MANIFEST.in is incorrect? I'm not sure why else pip would leave the files in place through a reinstall and upgrade. |
@Harmon758 I'm almost sure that pip only installs files listed in the manifest but then it tracks the old release files according to the older manifest so it should be fine. |
Actually, pip doesn't really know about |
Facing this issue with any version of aiohttp starting from 3.4.0 and with recently released yarl 1.5.0.
Using previous yarl==1.4.2 solves this issue (error is gone).
Thought it was old bug bubbling out: aio-libs/aiohttp#1364, but it seems that this issue is new.
The text was updated successfully, but these errors were encountered: