Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin yarl dependency to 1.4.2 as core dependency #38428

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Jul 31, 2020

Proposed change

This PR pins the yarl version as a core dependency, to 1.4.2.

Recently, 1.5.0 was introduced, which fixed this bug:

aio-libs/yarl#426

This effects how URLs parts are encoded and caused our google_translate integration to break (as strings are now double encoded). I'm opening a separate PR to fix that TTS integration.

Reason for not pinning 1.5.0: It looks like that version is a candidate for being pulled, see:

aio-libs/yarl#485

Type of change

  • Dependency upgrade pinning
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels Jul 31, 2020
@frenck frenck added this to the 0.113.3 milestone Jul 31, 2020
@frenck frenck merged commit f4c0dc9 into dev Jul 31, 2020
@frenck frenck deleted the frenck-2020-0727 branch July 31, 2020 20:06
@balloob balloob mentioned this pull request Aug 1, 2020
@frenck frenck mentioned this pull request Jan 10, 2021
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants