🪟🐛 Connector builder UI: Fix inputs modal (#21643)

* fix * fix Co-authored-by: Lake Mossman <[email protected]>
airbytehq · Jan 24, 2023 · 290b16b · 290b16b
1 parent 615bce0
commit 290b16b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/airbyte-webapp/src/components/connectorBuilder/Builder/BuilderField.tsx b/airbyte-webapp/src/components/connectorBuilder/Builder/BuilderField.tsx
@@ -149,7 +149,8 @@ const InnerBuilderField: React.FC<BuilderFieldProps & FastFieldProps<unknown>> =
 
 export const BuilderField: React.FC<BuilderFieldProps> = (props) => {
   return (
-    <FastField name={props.path}>
+    // The key is set to enforce a re-render of the component if the type change, otherwise changes in props might not be reflected correctly
+    <FastField name={props.path} key={props.type}>
       {({ field, form, meta }: FastFieldProps<unknown>) => (
         <InnerBuilderField {...props} field={field} form={form} meta={meta} />
       )}

diff --git a/airbyte-webapp/src/components/connectorBuilder/Builder/InputsForm.tsx b/airbyte-webapp/src/components/connectorBuilder/Builder/InputsForm.tsx
@@ -242,13 +242,6 @@ const InputModal = ({
                   label={formatMessage({ id: "connectorBuilder.inputModal.default" })}
                 />
               )}
-              <BuilderField
-                path="definition.placeholder"
-                type="string"
-                optional
-                label={formatMessage({ id: "connectorBuilder.inputModal.placeholder" })}
-                tooltip={formatMessage({ id: "connectorBuilder.inputModal.placeholderTooltip" })}
-              />
             </>
           ) : (
             <Callout className={styles.calloutContainer}>