🪟🐛 Connector builder UI: Fix inputs modal #21643
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes two small issues with the inputs modal:
How
For the first one, I tried for a bit to find a "real" solution, but it became way to complex to justify it here. The problem is that formik will not re-render the inner field if the value doesn't change which means changes in the props after the initial render might not be picked up correctly. I tried to come up with a generic way to enforce an update for any of the props, but there are two issues with this:
The solution I went with is adding a key prop to the fastfield with the type value so it will definitely re-render in this situation. It fixes the problem at hand and I hope we can soon refactor this code - with react-hook-form we won't have this problem.
For the second one - I checked and you are right, we don't support placeholders like this. I think this was a left-over from working from the original designs that included that field. I removed it.