-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🪟 🎨 New stream details panel (#19219)
* move all stream details table related components to separate folder; create the first version of table powered by current implementation of react-table; * init a copy of existing <Table /> component - <NextTable /> * fixed calc error * first implementation of NextTable: - use css modules instead of styled cmp - extracted base table styles - remove props used just for styling(customPadding, light, etc.) - no typings * remove StreamDetailsHeader * updated StreamFieldsTable * fix typings error * update NextTable cells classnames * remove last styled component from NextTable * add base tests for NextTable component * remove comments * replace "any" type with "unknown" where possible * add react-table v8 package * update NextTable component * update NextTable component * extend react-table ColumnMeta interface * update StreamFieldsTable component * update NextTable tests * update NextTable storybook * fixed crashed StreamConnectionHeader during connection creation * replace useConnectionEditService with useConnectionFormService hook * remove getIcon wrap function and combine all parts in separate component * update styles * extract common logic to separate function * fix performance * fix not capitalized table header cell * fix checkbox style issue * make thead sticky by default * fix not scrollable table * fixed top bar overflow during scrolling table * fix top bar overflow during scrolling table - second try * fix hidden cursor and pk columns * fix hidden cursor and pk columns * fix PR comments: replace css values with variables * remove unnecessary hook dependencies * fix relative import component path * add space around panel; add 100px top gap height * fix arrow color * align table padding with toggle * add ArrowRight icon from design replace faArrowRight with ArrowRight * move NextTable component to ui folder * move StreamDetailsPanel component to separate folder * move StreamPanelHeader component to separate folder * remove obsolete DetailsPanel components * move all DetailsPanel related components to separate folder * fix when no namespace * fixed details panel header sync mode label * fix relative import path * move react-table.d.ts to src/types * remove fake destination data type column * add FormattedMessage to ConnectorHeaderGroupIcon * fix StreamPanelHeader style to match Figma * change td color from grey-100 to grey-50 fix relative path * temporary remove @tanstack/react-table package * add @tanstack/react-table back to package.json * fix cross icon color fix items alignment in flex container
- Loading branch information
Showing
24 changed files
with
710 additions
and
212 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 0 additions & 19 deletions
19
airbyte-webapp/src/components/connection/CatalogTree/next/StreamDetailsPanel.module.scss
This file was deleted.
Oops, something went wrong.
27 changes: 27 additions & 0 deletions
27
.../components/connection/CatalogTree/next/StreamDetailsPanel/StreamDetailsPanel.module.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
@use "scss/colors"; | ||
@use "scss/variables" as vars; | ||
@use "scss/z-indices"; | ||
|
||
$container-left-space: vars.$spacing-xl; | ||
$container-right-space: vars.$spacing-xl * 2; | ||
|
||
.dialog { | ||
z-index: z-indices.$modal; | ||
} | ||
|
||
.container { | ||
position: fixed; | ||
bottom: 0; | ||
left: vars.$width-size-menu + $container-left-space; | ||
width: calc(100% - (vars.$width-size-menu + $container-right-space)); | ||
z-index: 1000; | ||
height: calc(100vh - 100px); | ||
background: colors.$white; | ||
border-radius: vars.$border-radius-2xl vars.$border-radius-2xl 0 0; | ||
box-shadow: 0 0 22px rgba(colors.$dark-blue-900, 12%); | ||
} | ||
|
||
.tableContainer { | ||
height: calc(100% - 64px); | ||
overflow: scroll; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
...atalogTree/next/StreamDetailsPanel/StreamFieldsTable/ConnectorHeaderGroupIcon.module.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
$connector-icon-size: 28px; | ||
|
||
.connectorIconContainer { | ||
display: flex; | ||
flex-direction: row; | ||
align-items: center; | ||
gap: 10px; | ||
} | ||
|
||
.icon { | ||
height: $connector-icon-size; | ||
width: $connector-icon-size; | ||
} |
20 changes: 20 additions & 0 deletions
20
...ection/CatalogTree/next/StreamDetailsPanel/StreamFieldsTable/ConnectorHeaderGroupIcon.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import React from "react"; | ||
import { FormattedMessage } from "react-intl"; | ||
|
||
import { getIcon } from "utils/imageUtils"; | ||
|
||
import styles from "./ConnectorHeaderGroupIcon.module.scss"; | ||
|
||
interface StreamHeaderGroupIconProps { | ||
type: "source" | "destination"; | ||
icon?: string; | ||
} | ||
|
||
export const ConnectorHeaderGroupIcon: React.FC<StreamHeaderGroupIconProps> = ({ type, icon }) => { | ||
return ( | ||
<span className={styles.connectorIconContainer}> | ||
<div className={styles.icon}>{getIcon(icon)}</div> | ||
<FormattedMessage id={`connector.${type}`} /> | ||
</span> | ||
); | ||
}; |
93 changes: 93 additions & 0 deletions
93
...ction/CatalogTree/next/StreamDetailsPanel/StreamFieldsTable/StreamFieldsTable.module.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,93 @@ | ||
@use "scss/colors"; | ||
@use "scss/variables"; | ||
|
||
$cell-height: 28px; | ||
$cell-left-padding: variables.$spacing-xl + variables.$spacing-sm; | ||
|
||
.customTableStyle { | ||
td { | ||
border-bottom-color: colors.$grey-50; | ||
} | ||
} | ||
|
||
.headerGroupCell { | ||
height: 58px; | ||
background-color: colors.$white; | ||
color: colors.$dark-blue; | ||
font-weight: 700; | ||
font-size: 16px; | ||
line-height: $cell-height; | ||
text-transform: capitalize; | ||
|
||
&:first-child { | ||
padding-left: $cell-left-padding; | ||
border-radius: 0; | ||
} | ||
|
||
&:last-child { | ||
padding-left: 0; | ||
} | ||
} | ||
|
||
.headerCell { | ||
color: colors.$grey; | ||
background-color: colors.$grey-50; | ||
height: $cell-height; | ||
font-weight: 400; | ||
font-size: 12px; | ||
line-height: 15px; | ||
text-transform: capitalize; | ||
|
||
&:first-child { | ||
padding-left: $cell-left-padding; | ||
border-radius: 0; | ||
} | ||
|
||
&:last-child { | ||
padding-left: 0; | ||
border-radius: 0; | ||
} | ||
} | ||
|
||
%bodyCell { | ||
height: $cell-height; | ||
padding: 0; | ||
|
||
&:first-child { | ||
padding-left: $cell-left-padding; | ||
border-radius: 0; | ||
} | ||
} | ||
|
||
.textCell { | ||
@extend %bodyCell; | ||
|
||
color: colors.$dark-blue; | ||
} | ||
|
||
.dataTypeCell { | ||
@extend %bodyCell; | ||
|
||
color: colors.$grey-400; | ||
} | ||
|
||
.arrowCell { | ||
@extend %bodyCell; | ||
|
||
svg { | ||
color: colors.$grey-200; | ||
} | ||
} | ||
|
||
.checkboxCell { | ||
display: flex; | ||
align-items: center; | ||
height: $cell-height; | ||
overflow: unset; | ||
padding-left: 0; | ||
} | ||
|
||
// need to fix styled-component z-index issue | ||
.checkbox { | ||
position: unset !important; | ||
} |
Oops, something went wrong.