Skip to content

Commit

Permalink
Sync cdk manifest between webapp and connector builder server (#22422)
Browse files Browse the repository at this point in the history
* do not rely on local cdk anymore

* cache versioned schemas

* fix used version

* centralize used CDK version

* fix dpath
  • Loading branch information
Joe Reuter authored Feb 7, 2023
1 parent 53098fe commit c955e61
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ jobs:
- 'airbyte-db/**'
frontend:
- 'airbyte-api/src/main/openapi/config.yaml'
- 'airbyte-connector-builder-server/CDK_VERSION'
- 'airbyte-connector-builder-server/src/main/openapi/openapi.yaml'
- 'airbyte-webapp/**'
- 'airbyte-webapp-e2e-tests/**'
Expand Down
1 change: 1 addition & 0 deletions airbyte-connector-builder-server/CDK_VERSION
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
0.25.0
4 changes: 3 additions & 1 deletion airbyte-connector-builder-server/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
# The text of the README file
README = (HERE / "README.md").read_text()

CDK_VERSION = (HERE / "CDK_VERSION").read_text()

setup(
name="connector-builder-server",
version="0.40.32",
Expand Down Expand Up @@ -41,7 +43,7 @@
},
packages=find_packages(exclude=("unit_tests", "integration_tests", "docs")),
package_data={},
install_requires=["airbyte-cdk==0.25", "fastapi", "uvicorn"],
install_requires=[f"airbyte-cdk=={CDK_VERSION}", "fastapi", "uvicorn"],
python_requires=">=3.9.11",
extras_require={
"tests": [
Expand Down
3 changes: 1 addition & 2 deletions airbyte-webapp/scripts/load-declarative-schema.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
set -e
mkdir -p build

# Make sure this is aligned with the CDK version of the connector builder server
DEFAULT_CDK_VERSION="0.25.0"
DEFAULT_CDK_VERSION=`cat ../airbyte-connector-builder-server/CDK_VERSION`

if [ -z "$CDK_VERSION" ]
then
Expand Down

0 comments on commit c955e61

Please sign in to comment.