Sync cdk manifest between webapp and connector builder server #22422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 5, 2023 11:37
flash1293
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
flash1293
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
Airbyte Code Coverage
|
lmossman
approved these changes
Feb 6, 2023
flash1293
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
flash1293
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
danidelvalle
pushed a commit
to danidelvalle/airbyte
that referenced
this pull request
Feb 9, 2023
…ehq#22422) * do not rely on local cdk anymore * cache versioned schemas * fix used version * centralize used CDK version * fix dpath
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21830 by making sure the connector builder server and the webapp always use the same CDK version.
This is done by a central file
CDK_VERSIONwhich is read by both the connector builder server setup and the webapp setup.Also makes sure the webapp is built when the cdk version changes (adds a forgotten dependency on the openapi spec of the connector builder server as well)