Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Google Ads: improve unit and integration tests #12650

Closed
davydov-d opened this issue May 6, 2022 · 1 comment · Fixed by #12651
Closed

Source Google Ads: improve unit and integration tests #12650

davydov-d opened this issue May 6, 2022 · 1 comment · Fixed by #12651
Assignees
@davydov-d
Labels
connectors/source/google-ads team/connectors-python

Comments

@davydov-d
Copy link
Collaborator

davydov-d commented May 6, 2022 •
edited
Loading

Goal:

  • unit test coverage at least 90%
  • mock unit tests so they do not use real network connections
  • all integration tests pass

Note: some of the SATs are disabled due to current constraints, so custom integration tests are implemented instead. The issue describes the problem and the solution. After it is implemented, SATs can be enabled
@davydov-d
Copy link
Collaborator Author

#11758

@davydov-d davydov-d self-assigned this May 6, 2022
davydov-d added a commit that referenced this issue May 6, 2022
@davydov-d
#12650 source Googel ads: tests
8f979df
@davydov-d davydov-d linked a pull request May 6, 2022 that will close this issue
Source Google Ads: Improve unit and integration tests #12651
Merged
davydov-d added a commit that referenced this issue May 6, 2022
@davydov-d
#12650 source google ads: add changelog item
a74fa28
davydov-d added a commit that referenced this issue May 9, 2022
@davydov-d
#12650 source google ads: add comments to tests
d892030
davydov-d added a commit that referenced this issue May 9, 2022
@davydov-d @octavia-squidington-iii
Source Google Ads: Improve unit and integration tests (#12651)
d4f8b25 
* #12650 source Googel ads: tests

* #12650 source google ads: add changelog item

* #12650 source google ads: add comments to tests

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>
davydov-d added a commit that referenced this issue May 12, 2022
@davydov-d
#12650: source google ads to GA: mock input config for unit tests
fdac436
davydov-d added a commit that referenced this issue May 12, 2022
@davydov-d
#12650 source google ads to GA: doc updates
3f4fbb4
davydov-d added a commit that referenced this issue May 12, 2022
@davydov-d
#12650 source google ads to GA: upd changelog
747ffde
davydov-d added a commit that referenced this issue May 13, 2022
@davydov-d
#12650 source GAds to GA: doc review fixes
08ee0dc
davydov-d added a commit that referenced this issue May 13, 2022
@davydov-d @octavia-squidington-iii
Source Google Ads to GA: update spec and docs (#12807)
e49faed 
* #12650: source google ads to GA: mock input config for unit tests

* #12650 source google ads to GA: doc updates

* #12650 source google ads to GA: upd changelog

* #12650 source GAds to GA: doc review fixes

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>
suhomud pushed a commit that referenced this issue May 23, 2022
@davydov-d @octavia-squidington-iii @suhomud
Source Google Ads: Improve unit and integration tests (#12651)
5e4b8e9 
* #12650 source Googel ads: tests

* #12650 source google ads: add changelog item

* #12650 source google ads: add comments to tests

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>
suhomud pushed a commit that referenced this issue May 23, 2022
@davydov-d @octavia-squidington-iii @suhomud
Source Google Ads to GA: update spec and docs (#12807)
9c423b7 
* #12650: source google ads to GA: mock input config for unit tests

* #12650 source google ads to GA: doc updates

* #12650 source google ads to GA: upd changelog

* #12650 source GAds to GA: doc review fixes

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davydov-d davydov-d

Labels
connectors/source/google-ads team/connectors-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Source Google Ads: Improve unit and integration tests airbytehq/airbyte
2 participants
@davydov-d @octavia-squidington-iii