Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Google Ads to GA: update spec and docs #12807

Merged
merged 5 commits into from
May 13, 2022
Merged

Source Google Ads to GA: update spec and docs #12807

merged 5 commits into from
May 13, 2022

Conversation

davydov-d
Copy link
Collaborator

What

  1. Mock config in unit tests
  2. update spec.json
  3. update docs

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 12, 2022
@davydov-d
Copy link
Collaborator Author

davydov-d commented May 12, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2313317137
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2313317137
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/__init__.py                  2      0   100%
source_google_ads/google_ads.py               68     10    85%
source_google_ads/streams.py                 138     21    85%
source_google_ads/source.py                   80     27    66%
source_google_ads/custom_query_stream.py      75     50    33%
--------------------------------------------------------------
TOTAL                                        363    108    70%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/__init__.py                  2      0   100%
source_google_ads/source.py                   80      3    96%
source_google_ads/streams.py                 138     11    92%
source_google_ads/custom_query_stream.py      75      6    92%
source_google_ads/google_ads.py               68     14    79%
--------------------------------------------------------------
TOTAL                                        363     34    91%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 21 passed, 1 skipped in 363.55s (0:06:03) ===================

@davydov-d davydov-d self-assigned this May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@f918859). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #12807   +/-   ##
=========================================
  Coverage          ?   90.63%           
=========================================
  Files             ?        5           
  Lines             ?      363           
  Branches          ?        0           
=========================================
  Hits              ?      329           
  Misses            ?       34           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f918859...98d212d. Read the comment docs.

@davydov-d davydov-d linked an issue May 12, 2022 that may be closed by this pull request
Source Google Ads: Update Docs #12810
Closed
pedroslopez
pedroslopez approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@pedroslopez pedroslopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor grammar notes, but looks good!

docs/integrations/sources/google-ads.md Outdated Show resolved Hide resolved
docs/integrations/sources/google-ads.md Outdated Show resolved Hide resolved
docs/integrations/sources/google-ads.md Outdated Show resolved Hide resolved
@davydov-d
Copy link
Collaborator Author

davydov-d commented May 13, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2320730721
🚀 Successfully published connectors/source-google-ads
🚀 Auto-bumped version for connectors/source-google-ads
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2320730721

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 13, 2022 17:04 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 13, 2022 17:05 Inactive
@davydov-d davydov-d merged commit e49faed into master May 13, 2022
@davydov-d davydov-d deleted the ddavydov/12650-source-google-ads-to-ga-update-docs branch May 13, 2022 17:31
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request May 17, 2022
Merged
suhomud pushed a commit that referenced this pull request May 23, 2022
@davydov-d @octavia-squidington-iii @suhomud
Source Google Ads to GA: update spec and docs (#12807)
9c423b7 
* #12650: source google ads to GA: mock input config for unit tests

* #12650 source google ads to GA: doc updates

* #12650 source google ads to GA: upd changelog

* #12650 source GAds to GA: doc review fixes

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midavadim midavadim midavadim approved these changes

@pedroslopez pedroslopez pedroslopez approved these changes

@bazarnov bazarnov bazarnov approved these changes

Assignees

@davydov-d davydov-d

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Google Ads: Update Docs
5 participants
@davydov-d @midavadim @pedroslopez @bazarnov @octavia-squidington-iii