🪟 🧹 Add cron string to segment calls, remove outdated schedule property use
#17672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… return value format
github-actions
bot
added
area/platform
…irbytehq/airbyte into teal/remove-schedule-property-from-api
teallarson
commented
Oct 6, 2022
| onStatusUpdating={onStatusUpdating} | ||
| disabled={!allowSync} | ||
| connection={connection} | ||
| frequencyType={getFrequencyType(connection.scheduleData?.basicSchedule)} |
There was a problem hiding this comment.
This can be figured out directly in the child component from the connection object.
#15609 tracks converting the child component to use the service and remove the need to send connection as a prop at all.
edmundito
reviewed
Oct 6, 2022
krishnaglick
approved these changes
Oct 6, 2022
|
Yes @krishnaglick I ran it past @nataliekwong in Slack! |
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
…erty use (airbytehq#17672) * update segment schedule frequency calls to include cron string, unify return value format * remove unused frequencyType prop * cleanup * rename and move util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This updates the code still using the
connection.scheduleproperty for an analytics call (and only for that analytics call). We also had a few different formats that we were sendingfrequencydata.Now, all frequency data is sent as either:
I did leave the dropdown analytics call as it was since that call seemed focused specifically on what a user chooses from the dropdown.
How
Updated the schedule util to produce human readable strings from the
scheduleDataobject. Utilize this method in the analytics calls.Recommended reading order
util.tsxNote:
After this, we will be able to fully remove the
scheduleproperty fromWebBackendConnectionRead🚨 User Impact 🚨
None