-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[connector builder] limit the number of requests submitted to the endpoint #20771
Labels
Comments
girarda
added
type/enhancement
New feature or request
team/extensibility
area/connector-builder
labels
Dec 21, 2022
Related to that and also important:
|
Side note: Should we cancel the read once the upstream connection gets closed? Might be separate issue |
maxi297
added a commit
that referenced
this issue
Jan 18, 2023
maxi297
added a commit
that referenced
this issue
Jan 19, 2023
maxi297
added a commit
that referenced
this issue
Jan 19, 2023
maxi297
added a commit
that referenced
this issue
Jan 19, 2023
maxi297
added a commit
that referenced
this issue
Jan 19, 2023
maxi297
added a commit
that referenced
this issue
Jan 20, 2023
maxi297
added a commit
that referenced
this issue
Jan 20, 2023
maxi297
added a commit
that referenced
this issue
Jan 20, 2023
* [ISSUE #20771] adding slices to connector builder read request * [ISSUE #20771] formatting * [ISSUE #20771] set flag when limit requests reached (#21619) * [ISSUE #20771] set flag when limit requests reached * [ISSUE #20771] assert proper value on test read objects __init__ * [ISSUE #20771] code review and fix edge case
maxi297
added a commit
that referenced
this issue
Jan 20, 2023
maxi297
added a commit
that referenced
this issue
Jan 24, 2023
maxi297
added a commit
that referenced
this issue
Jan 24, 2023
#21525) * [ISSUE #20771] limiting the number of requests performed to the backend without flag * [ISSUE #20771] code reviewing my own code * [ISSUE #20771] adding ABC to paginator * [ISSUE #20771] format code * [ISSUE #20771] adding slices to connector builder read request (#21605) * [ISSUE #20771] adding slices to connector builder read request * [ISSUE #20771] formatting * [ISSUE #20771] set flag when limit requests reached (#21619) * [ISSUE #20771] set flag when limit requests reached * [ISSUE #20771] assert proper value on test read objects __init__ * [ISSUE #20771] code review and fix edge case * [ISSUE #20771] fix flake8 error * [ISSUE #20771] code review * 🤖 Bump minor version of Airbyte CDK * to run the CI
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Tell us about the problem you're trying to solve
We should limit the number of requests the connector builder can send as part of a "test read" to limit how expensive a read is.
As a result:
Describe the solution you’d like
A way to limit the number of requests submitted to an API endpoint because of a single "test read"
Acceptance criteria
Implementation details
HttpStream
so it stops paginating after X requestsAbstractSource
so it stops iterating over the stream slices after X requestsOpen questions
The text was updated successfully, but these errors were encountered: