[ISSUE #20771] adding slices to connector builder read request #21605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to test this - I think there is some code in there to handle multiple slices but as you noted it's not used at the moment. But it's not blocking for this PR, we can also fix it as a follow-up. |
…issue-20771_adding-slices-to-read-response
|
@girarda if you are interested |
|
There is no test that validates that |
girarda
reviewed
Jan 19, 2023
girarda
approved these changes
Jan 19, 2023
maxi297
added a commit
that referenced
this pull request
Jan 24, 2023
#21525) * [ISSUE #20771] limiting the number of requests performed to the backend without flag * [ISSUE #20771] code reviewing my own code * [ISSUE #20771] adding ABC to paginator * [ISSUE #20771] format code * [ISSUE #20771] adding slices to connector builder read request (#21605) * [ISSUE #20771] adding slices to connector builder read request * [ISSUE #20771] formatting * [ISSUE #20771] set flag when limit requests reached (#21619) * [ISSUE #20771] set flag when limit requests reached * [ISSUE #20771] assert proper value on test read objects __init__ * [ISSUE #20771] code review and fix edge case * [ISSUE #20771] fix flake8 error * [ISSUE #20771] code review * 🤖 Bump minor version of Airbyte CDK * to run the CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In order to validate if the number of requests was limited, we want to be able to know how many pages and slices were queries. We already had the information for the pages but didn't for the slices. This PR addresses the slices part.
How
Emit a log message when a new slice is being started and catch this log message to create the slices properly
Recommended reading order
airbyte-cdk/python/airbyte_cdk/sources/abstract_source.py: how the slice message is loggedairbyte-connector-builder-server/connector_builder/impl/default_api.py: how we use this log message to create the slices on the connector-builder server🚨 User Impact 🚨
@flash1293, will this be supported by the UI? Although not a breaking API change, there were some assumptions in the backend that there will always be only one slice.