Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Story] Completely update all base-python connectors, use CDK package instead #7242

Closed
36 tasks done
yevhenii-ldv opened this issue Oct 21, 2021 · 3 comments
Closed
36 tasks done

[Story] Completely update all base-python connectors, use CDK package instead #7242

yevhenii-ldv opened this issue Oct 21, 2021 · 3 comments
Assignees
@vitaliizazmic
Labels
area/connectors Connector related issues connectors/source/apify-dataset connectors/source/bigcommerce connectors/source/dixa connectors/source/drift connectors/source/freshdesk connectors/source/google-directory connectors/source/google-sheets connectors/source/google-workspace-admin-reports connectors/source/hubspot connectors/source/intercom connectors/source/jira connectors/source/linkedin-ads connectors/source/looker connectors/source/microsoft-teams connectors/source/mixpanel connectors/source/paypal-transaction connectors/source/pokeapi connectors/source/recurly connectors/source/s3 connectors/source/slack connectors/source/smartsheets connectors/source/snapchat-marketing connectors/source/square connectors/source/tiktok-marketing connectors/source/trello connectors/source/us-census connectors/source/zendesk-chat connectors/source/zendesk-talk connectors/sources-api connectors/sources-database connectors/sources-files lang/python type/enhancement New feature or request
Milestone
Connectors Dec 24...

Comments

@yevhenii-ldv
Copy link
Contributor

yevhenii-ldv commented Oct 21, 2021 •
edited by vitaliizazmic
Loading

Part of #6164 epic

Currently we have a lot of connectors using base-python package.
In this story, we need to use the classes and methods from the СDK instead of using them from the base-python package for following connectors:

Note: Please, before starting the new task - please create a separate issue for it and edit the description by adding a link.
@yevhenii-ldv yevhenii-ldv added type/enhancement New feature or request lang/python labels Oct 21, 2021
@yevhenii-ldv yevhenii-ldv self-assigned this Oct 21, 2021
@yevhenii-ldv yevhenii-ldv added this to the Connectors 2021-10-29 milestone Oct 21, 2021
@sherifnada
Copy link
Contributor

@yevhenii-ldv I think for the vast majority of these, they don't actually depend on base-python and it's just because the template generator had (maybe still has?) base-python in it

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 22, 2021 •
edited
Loading

@sherifnada yep, agree with you. I think it is possible in one PR to remove this unnecessary dependency from all build.gradle files for connectors in which this dependency is superfluous.

@yevhenii-ldv yevhenii-ldv mentioned this issue Oct 26, 2021
Merged
5 tasks
This was referenced Oct 27, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Merged
@htrueman htrueman mentioned this issue Oct 29, 2021
Merged
38 tasks
@htrueman
Copy link
Contributor

htrueman commented Nov 1, 2021 •
edited
Loading

These connectors were refactored in #7499, so no need to create a separate issues for them:
source-apify-dataset,
source-bigcommerce,
source-dixa,
source-exchange-rates,
source-intercom,
source-linkedin-ads,
source-mixpanel,
source-paypal-transaction,
source-s3,
source-scaffold-source-http,
source-scaffold-source-python,
source-shortio,
source-slack,
source-smartsheets,
source-snapchat-marketing,
source-square,
source-tiktok-marketing,
source-trello,
source-us-census,
source-woocommerce

@sherifnada sherifnada mentioned this issue Nov 8, 2021
Merged
18 tasks
@sherifnada sherifnada added the area/connectors Connector related issues label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitaliizazmic vitaliizazmic

Labels
area/connectors Connector related issues connectors/source/apify-dataset connectors/source/bigcommerce connectors/source/dixa connectors/source/drift connectors/source/freshdesk connectors/source/google-directory connectors/source/google-sheets connectors/source/google-workspace-admin-reports connectors/source/hubspot connectors/source/intercom connectors/source/jira connectors/source/linkedin-ads connectors/source/looker connectors/source/microsoft-teams connectors/source/mixpanel connectors/source/paypal-transaction connectors/source/pokeapi connectors/source/recurly connectors/source/s3 connectors/source/slack connectors/source/smartsheets connectors/source/snapchat-marketing connectors/source/square connectors/source/tiktok-marketing connectors/source/trello connectors/source/us-census connectors/source/zendesk-chat connectors/source/zendesk-talk connectors/sources-api connectors/sources-database connectors/sources-files lang/python type/enhancement New feature or request
Projects
None yet
Milestone
Connectors Dec 24 2021
Development

No branches or pull requests
8 participants
@sherifnada @karinakuz @htrueman @yevhenii-ldv @VasylLazebnyk @vitaliizazmic @igrankova @ycherniaiev