Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Recurly: refactor to use the CDK #8318

Closed
vitaliizazmic opened this issue Nov 29, 2021 · 3 comments · Fixed by #8468
Closed

Source Recurly: refactor to use the CDK #8318

vitaliizazmic opened this issue Nov 29, 2021 · 3 comments · Fixed by #8468
Assignees
@vitaliizazmic
Labels
area/connectors Connector related issues connectors/source/recurly connectors/sources-api type/enhancement New feature or request
Milestone
Connectors Dec 10...

Comments

@vitaliizazmic
Copy link
Contributor

The Recurly connector currently uses an old pattern, we should migrate it to use the new CDK. It's part of #6164.

Describe the solution you’d like

see #6164 for clearer instructions
@vitaliizazmic vitaliizazmic added type/enhancement New feature or request area/connectors Connector related issues labels Nov 29, 2021
@vitaliizazmic vitaliizazmic added this to the Connectors Dec 10 2021 milestone Nov 29, 2021
@vitaliizazmic vitaliizazmic self-assigned this Nov 29, 2021
This was referenced Nov 29, 2021
Closed
Merged
@mohamagdy
Copy link
Contributor

@vitaliizazmic @sherifnada any work done to migrate Recurly to CDK yet? If not, I can work on it as we need an incremental sync mode for the Recurly source and it will make more sense to add the incremental sync mode after migrating to CDK and not extending the base-python Recurly connector, right?

@sherifnada
Copy link
Contributor

hi @mohamagdy ! It should be moved soon -- vitalii is managing it. Afterwards we'd be more than happy to support a contribution!

@mohamagdy
Copy link
Contributor

Hi @sherifnada,

Sounds like a plan. Looking forward to it. Thanks for the update.

vitaliizazmic added a commit that referenced this issue Dec 6, 2021
@vitaliizazmic
Source Recurly #8318 - reformat
719e82d
vitaliizazmic added a commit that referenced this issue Dec 6, 2021
@vitaliizazmic
🎉 Source Recurly: migrate to the CDK
79acc2b 
* Source Microsoft Teams #8315 - migrate to  the CDK

* Source Microsoft Teams #8315 - acceptances test

* Source Microsoft Teams #8315 - fixed schemas

* Source Microsoft Teams #8315 - reformat

* Source Microsoft Teams #8315 - bump version

* Source Recurly #8318 - reformat
schlattk pushed a commit to schlattk/airbyte that referenced this issue Jan 4, 2022
@vitaliizazmic @schlattk
🎉 Source Recurly: migrate to the CDK
e3f4b24 
* Source Microsoft Teams airbytehq#8315 - migrate to  the CDK

* Source Microsoft Teams airbytehq#8315 - acceptances test

* Source Microsoft Teams airbytehq#8315 - fixed schemas

* Source Microsoft Teams airbytehq#8315 - reformat

* Source Microsoft Teams airbytehq#8315 - bump version

* Source Recurly airbytehq#8318 - reformat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitaliizazmic vitaliizazmic

Labels
area/connectors Connector related issues connectors/source/recurly connectors/sources-api type/enhancement New feature or request
Projects
None yet
Milestone
Connectors Dec 10 2021
Development

Successfully merging a pull request may close this issue.

🎉 Source Recurly: migrate to the CDK airbytehq/airbyte
4 participants
@mohamagdy @sherifnada @vitaliizazmic @igrankova