-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPIC] Completely deprecate and remove base-python and base-singer packages #6164
Labels
area/connectors
Connector related issues
autoteam
cleanup
Epic
team/extensibility
type/enhancement
New feature or request
Comments
sherifnada
added
type/enhancement
New feature or request
area/connectors
Connector related issues
labels
Sep 17, 2021
sherifnada
changed the title
Completely deprecate and remove base-python and base-singer packages
[EPIC] Completely deprecate and remove base-python and base-singer packages
Sep 17, 2021
This was referenced Oct 14, 2021
This was referenced Oct 21, 2021
10 tasks
This was referenced Oct 27, 2021
This was referenced Nov 1, 2021
This was referenced Nov 8, 2021
This was referenced Nov 29, 2021
This was referenced Dec 2, 2021
This was referenced Dec 2, 2021
10 tasks
This was referenced May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
autoteam
cleanup
Epic
team/extensibility
type/enhancement
New feature or request
Tell us about the problem you're trying to solve
Before releasing the CDK, we relied on the base-python and base-singer packages. However, now that we have the CDK (which still supports singer) there is no reason to keep these packages around. Keeping them around is clutter and increases the build time.
base-python
(an easy way is to grep forimplementation files(project(':airbyte-integrations:bases:base-python').airbyteDocker.outputs)
in gradle build files)base-python
(i.e: it relies on the CDK from PyPi and its Docker image inherits from a python image directly, not an airbyte special image e.g:FROM python:3.7-slim
notFROM airbyte/base-integration-python
. In this case, removing the line in the gradle build file is sufficient.deprecated
package of the CDK published on Pypi. You'll need to migrate the connector's usages to that subpackage.In every case, make sure to remove the line in the gradle file which depends on the
base-
package.For base-singer, do the same but ignore the following modules:
All of these will soon be replaced with non-singer modules and removed soon.
I recommend that a single person lead this effort at first to get a sense of how to perform this task, then parallelize it with someone else on the team as needed.
Important: please create a subticket for each connector you work on to help us keep visibility.
The text was updated successfully, but these errors were encountered: