remove CONTAINER_ORCHESTRATOR env var from acceptance tests #14541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmossman
deleted the
lmossman/remove-container-orchestrator-acceptance-test-env-var
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The ContainerOrchestratorAcceptanceTests were recently added in this PR: #13699
However, very quickly after merging I realized that it is redundant to use the
CONTAINER_ORCHESTRATORenv variable in the acceptance test files, because we could just use theKUBEflag to achieve the same result (since all kube deploys now use container orchestrators).How
This PR simply uses the
KUBEflag to decide to run the container orchestrator tests instead.