Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove CONTAINER_ORCHESTRATOR env var from acceptance tests #14541

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,12 @@
* This class tests behavior that is specific to container-orchestrator deployments, such as scaling
* down and back up workers while a sync is running to ensure it is not affected by a deployment.
* <p>
* This test class is only enabled if the CONTAINER_ORCHESTRATOR environment variable is true. At
* the time of writing, this is only the case for kubernetes deployments, as container orchestrators
* have not yet been ported over to docker.
* This test class is only enabled if the KUBE environment variable is true, because container
* orchestrators are currently only used by kuberenetes deployments, as container orchestrators have
* not yet been ported over to docker.
*/
@SuppressWarnings({"rawtypes", "ConstantConditions"})
@EnabledIfEnvironmentVariable(named = "CONTAINER_ORCHESTRATOR",
@EnabledIfEnvironmentVariable(named = "KUBE",
matches = "true")
public class ContainerOrchestratorAcceptanceTests {

Expand Down
2 changes: 1 addition & 1 deletion tools/bin/acceptance_test_kube.sh
Original file line number Diff line number Diff line change
Expand Up @@ -76,4 +76,4 @@ if [ -n "$CI" ]; then
fi

echo "Running e2e tests via gradle..."
KUBE=true CONTAINER_ORCHESTRATOR=true SUB_BUILD=PLATFORM USE_EXTERNAL_DEPLOYMENT=true ./gradlew :airbyte-tests:acceptanceTests --scan
KUBE=true SUB_BUILD=PLATFORM USE_EXTERNAL_DEPLOYMENT=true ./gradlew :airbyte-tests:acceptanceTests --scan
Original file line number Diff line number Diff line change
Expand Up @@ -68,5 +68,5 @@ kubectl port-forward svc/postgres-destination-svc 3000:5432 --namespace=$NAMESPA
sleep 10s

echo "Running e2e tests via gradle..."
KUBE=true IS_GKE=true CONTAINER_ORCHESTRATOR=true SUB_BUILD=PLATFORM USE_EXTERNAL_DEPLOYMENT=true ./gradlew :airbyte-tests:acceptanceTests --scan -i
KUBE=true IS_GKE=true SUB_BUILD=PLATFORM USE_EXTERNAL_DEPLOYMENT=true ./gradlew :airbyte-tests:acceptanceTests --scan -i