Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment out flaky test suite while it is being investigated #16752

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

lmossman
Copy link
Contributor

@lmossman lmossman commented Sep 14, 2022

What

The connection FE E2E test suite is being very flaky recently. This PR comments out the test suite temporarily while we investigate what is going on, so that other teams are not blocked.

See slack thread for context: https://airbytehq-team.slack.com/archives/C03088BTMFC/p1663186255780899

How

Comment out the flaky test suite.

@lmossman lmossman marked this pull request as ready for review September 14, 2022 21:26
@lmossman lmossman requested a review from a team as a code owner September 14, 2022 21:26
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, but perhaps the way to go would have been to comment out the github action that runs the test (if that's how it works)

@lmossman
Copy link
Contributor Author

lmossman commented Sep 14, 2022

I think we still want to run the other frontend E2E tests. As far as I can tell this one test is the only one that is being flaky. And it is just one github action that runs all of the E2E test suites

@lmossman lmossman merged commit ed1ff03 into master Sep 14, 2022
@lmossman lmossman deleted the lmossman/comment-out-flaky-test-suite branch September 14, 2022 21:45
letiescanciano added a commit that referenced this pull request Sep 15, 2022
* master: (200 commits)
  🪟 🧹 Display returned error messages on replication view (#16280)
  🎉 Source mixpanel: Use "Retry-After" header for backoff (#16770)
  🐛 Source google ads: mark custom query fields required (#15858)
  🪟 🔧Remove useRouter hook (#16598)
  CDK: improve TypeTransformer to convert simple types to array of simple types (#16636)
  CDK: TypeTransformer - warning message more informative (#16695)
  Source MySQL: Add Python SAT to detect backwards breaking changes (#16445)
  remove eager (#16756)
  bump com.networknt:json-schema-validator to latest version (#16619)
  Remove Cloud from Kafka docs (#16753)
  Normalization Summaries table and read/write methods (#16655)
  comment out flaky test suite while it is being investigated (#16752)
  Update ConfigRepository to read protocol version (#16670)
  Use LOG4J2 to wrap connectors logs to JSON format (#15668)
  Update connector catalog (#16749)
  🪟 🎨 Remove feedback modal from UI (#16548)
  Add missing env var for Kube overlays (#16747)
  Prepare for React v18 upgrade (#16694)
  🪟 🐛 Fix direct job linking to work with pagination (#16517)
  Fix formatting (#16743)
  ...
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants