make FE E2E tests more reliable #16759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmossman
force-pushed
the
lmossman/fix-fe-e2e
branch
from
57ad0bc
to
eb25d71
Compare
github-actions
bot
added
area/platform
lmossman
commented
Sep 16, 2022
| ); | ||
|
|
||
| return React.createElement(as, { | ||
| ...remainingProps, |
There was a problem hiding this comment.
This was needed so that the data-id prop passed in here is actually set on the resulting element, so that our cypress tests still work
SofiiaZaitseva
approved these changes
Sep 17, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* make tests more reliable * switch back to localhost * run test 100 times * pass props through to Text element * ensure names are unique from one test run to the next * fix test result check
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* make tests more reliable * switch back to localhost * run test 100 times * pass props through to Text element * ensure names are unique from one test run to the next * fix test result check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Our frontend E2E connection tests have been failing more often than normal. They were temporarily disabled in #16752 in order to not block other teams.
The goal of this PR is to make the tests more reliable so that they do not fail so often.
How
This PR aims to make them more reliable by making a few changes: