Remove the dependency between the orchestrator container and the worker app #17570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
|
NOTE
|
benmoriceau
changed the title
|
NOTE
|
|
NOTE
|
|
NOTE
|
|
NOTE
|
|
NOTE
|
…ove-dep-container-orchestrator-worker
|
@colesnodgrass @alovew The build should pass so it is ready to review. |
|
NOTE
|
|
NOTE
|
colesnodgrass
approved these changes
Oct 11, 2022
|
@colesnodgrass @jdpgrailsdev I have added 628b721 to fix the acceptance test. |
…ove-dep-container-orchestrator-worker
|
NOTE
|
|
NOTE
|
benmoriceau
deleted the
bmoric/remove-dep-container-orchestrator-worker
branch
This was referenced Oct 13, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
…er app (airbytehq#17570) * test [ci skip] * Autogenerated files * Add missing annotation * Remove unused json2Schema block from worker * Move tess * Missing deps and format * Fix test build * Add missing dependencies * PR comments * Fix acceptance test and add the seed dependency * Fix build * Fix build again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the dependency from the orchestrator app to the worker app.
It is done by adding a new module
airbyte-commons-worker. This module is containing the classes needed by theairbyte-container-orchestratorto the common module.Recommended reading order
build.gradleofairbyte-container-orchestrator-> remove the worker dependenciesairbyte-commons-workerthat contains a set of files that are move from the worker module to the commons worker module.