-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the dependency between the orchestrator container and the worker app #17570
Merged
benmoriceau
merged 17 commits into
master
from
bmoric/remove-dep-container-orchestrator-worker
Oct 12, 2022
Merged
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
33b83bf
test [ci skip]
benmoriceau 4134048
Remove the dependency between orchestrator APP and the worker
benmoriceau 0d20286
Merge branch 'master' into bmoric/remove-dep-container-orchestrator-w…
benmoriceau d37bc19
Autogenerated files
benmoriceau bcf3431
Add missing annotation
benmoriceau db1f95d
Remove unused json2Schema block from worker
benmoriceau e7d1592
Move tess
benmoriceau 0881cee
Missing deps and format
benmoriceau 5c74045
Fix test build
benmoriceau 7e2d449
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/rem…
benmoriceau 390b8eb
Add missing dependencies
benmoriceau 4b6634d
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/rem…
benmoriceau cbae067
PR comments
benmoriceau 628b721
Fix acceptance test and add the seed dependency
benmoriceau 4c0de3c
Fix build
benmoriceau a3bce17
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/rem…
benmoriceau 644d83f
Fix build again
benmoriceau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
import org.jsonschema2pojo.SourceType | ||
|
||
plugins { | ||
id "java-library" | ||
id 'com.github.eirnym.js2p' version '1.0' | ||
} | ||
|
||
dependencies { | ||
annotationProcessor platform(libs.micronaut.bom) | ||
annotationProcessor libs.bundles.micronaut.annotation.processor | ||
|
||
implementation platform(libs.micronaut.bom) | ||
implementation libs.bundles.micronaut | ||
|
||
implementation 'io.fabric8:kubernetes-client:5.12.2' | ||
implementation 'io.temporal:temporal-sdk:1.8.1' | ||
implementation 'org.apache.ant:ant:1.10.10' | ||
implementation 'org.apache.commons:commons-text:1.9' | ||
|
||
implementation project(':airbyte-commons-protocol') | ||
implementation project(':airbyte-commons-temporal') | ||
implementation project(':airbyte-config:config-models') | ||
implementation project(':airbyte-json-validation') | ||
implementation project(':airbyte-metrics:metrics-lib') | ||
implementation project(':airbyte-persistence:job-persistence') | ||
implementation project(':airbyte-protocol:protocol-models') | ||
|
||
testAnnotationProcessor platform(libs.micronaut.bom) | ||
testAnnotationProcessor libs.bundles.micronaut.test.annotation.processor | ||
|
||
testImplementation libs.bundles.micronaut.test | ||
testImplementation 'com.jayway.jsonpath:json-path:2.7.0' | ||
testImplementation 'org.mockito:mockito-inline:4.7.0' | ||
testImplementation libs.postgresql | ||
testImplementation libs.platform.testcontainers | ||
testImplementation libs.platform.testcontainers.postgresql | ||
|
||
testImplementation project(':airbyte-commons-docker') | ||
} | ||
|
||
jsonSchema2Pojo { | ||
sourceType = SourceType.YAMLSCHEMA | ||
source = files("${sourceSets.main.output.resourcesDir}/workers_models") | ||
targetDirectory = new File(project.buildDir, 'generated/src/gen/java/') | ||
removeOldOutput = true | ||
|
||
targetPackage = 'io.airbyte.persistence.job.models' | ||
|
||
useLongIntegers = true | ||
generateBuilders = true | ||
includeConstructors = false | ||
includeSetters = true | ||
} | ||
|
||
Task publishArtifactsTask = getPublishArtifactsTask("$rootProject.ext.version", project) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
#!/usr/bin/env bash | ||
|
||
set -e | ||
|
||
function _error() { | ||
echo "$@" && exit 1 | ||
} | ||
|
||
function _usage() { | ||
_error "Usage: ./image_exists.sh imageName" | ||
} | ||
|
||
function docker_exists_in_local() { | ||
docker inspect --type=image "$1" 2> /dev/null | jq '. | length' | ||
} | ||
|
||
main() { | ||
[[ $# -eq 1 ]] || _usage | ||
imageName=$1 | ||
|
||
echo "Checking if ${imageName} exists..." | ||
# handle the case where the image exists ONLY on the local machine. | ||
LOCAL=$(docker_exists_in_local ${imageName}) | ||
|
||
if [[ $LOCAL -eq 0 ]]; then | ||
echo "${imageName} not found locally. Attempting to pull the image..." | ||
# handle the case where the image exists in the remote and either has never been pulled or has already been pulled | ||
# and is already up to date. | ||
RESULT=$(docker pull $imageName 2> /dev/null | awk '/Status: Image is up to date/ || /Status: Downloaded newer image/') | ||
[ -z "$RESULT" ] && _error "Image does not exist." | ||
echo "Pulled ${imageName} from remote." | ||
else | ||
echo "${imageName} was found locally." | ||
fi | ||
|
||
exit 0 | ||
} | ||
|
||
main "$@" |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the correct target package for these generated classes? If it is, should we use this change to rename it to better reflect that it is worker models and not persistence job models?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to limit the change of the PR so the package name are the same than the ones in the worker module. I'll included it in #17809. Does it sounds ok to you?