Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract source definition api #18977

Merged
merged 16 commits into from
Nov 7, 2022
Merged

Conversation

benmoriceau
Copy link
Contributor

What

In order to be prepared for a smoother migration to Micronaut for the server, an effort must be made to break the ConfigurationApi into multiple classes. This PR is the first one of a series of PR to come.

How

Extract the SourceDefinitionApi into its own class

Recommended reading order

No specific order

@github-actions github-actions bot added area/platform issues related to the platform area/server labels Nov 4, 2022
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@benmoriceau benmoriceau requested a review from a team as a code owner November 4, 2022 22:42
@github-actions github-actions bot added the area/frontend Related to the Airbyte webapp label Nov 4, 2022
@benmoriceau benmoriceau temporarily deployed to more-secrets November 4, 2022 22:44 Inactive
Base automatically changed from bmoric/extract-source-api to master November 4, 2022 23:54
@benmoriceau benmoriceau temporarily deployed to more-secrets November 5, 2022 00:00 Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets November 7, 2022 19:20 Inactive
@benmoriceau benmoriceau merged commit 29676e1 into master Nov 7, 2022
@benmoriceau benmoriceau deleted the bmoric/extract-source-definition-api branch November 7, 2022 20:01
letiescanciano added a commit that referenced this pull request Nov 8, 2022
…nent

* master:
  🪟 🎉 Enable frontend validation for <1hr syncs (cloud) #19028
  Stream returns AirbyteMessages (#18572)
  🎉 New Source - Recruitee [low-code SDK] (#18671)
  🎉 New source: Breezometer [low-code cdk] (#18650)
  Check disabled connections after protocol update (#18990)
  Simple default replication worker refactor (#19002)
  🎉 New Source: Visma e-conomic (#18595)
  🎉 New Source: Fastbill (#18593)
  Bmoric/extract state api (#18980)
  🎉 New Source: Zapier Supported Storage (#18442)
  🎉 New source: Klarna (#18385)
  `AirbyteEstimateTraceMessage` (#18875)
  Extract source definition api (#18977)
  [low-code cdk] Allow for spec file to be defined in the yaml manifest instead of an external file (#18411)
  🐛 Source HubSpot: fix property scopes (#18624)
  Ensure that only 6-character hex values are passed to monaco editor (#18943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform area/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants