Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🎉 Enable frontend validation for <1hr syncs (cloud) #19028

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

josephkmh
Copy link
Contributor

What

Disables sub 1hr syncs for cloud users

How

This validation logic was already merged, but toggled off via the FeatureItem.AllowSyncSubOneHourCronExpressions flag. This PR removes this flag in production, except for a segment of cloud customers who need to sync more frequently than 1hr:

image

@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Nov 7, 2022
@josephkmh josephkmh added area/frontend team/compose and removed area/platform issues related to the platform labels Nov 7, 2022
@josephkmh josephkmh changed the title disable sub 1hr syncs on cloud 🪟 🎉 Enable frontend validation for <1hr syncs (cloud) Nov 7, 2022
@josephkmh josephkmh marked this pull request as ready for review November 7, 2022 14:29
@josephkmh josephkmh requested a review from a team as a code owner November 7, 2022 14:29
Copy link
Contributor

@ambirdsall ambirdsall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@josephkmh josephkmh merged commit 7067977 into master Nov 8, 2022
@josephkmh josephkmh deleted the joey/disable-sub-hour-syncs-cloud branch November 8, 2022 07:17
letiescanciano added a commit that referenced this pull request Nov 8, 2022
…nent

* master:
  🪟 🎉 Enable frontend validation for <1hr syncs (cloud) #19028
  Stream returns AirbyteMessages (#18572)
  🎉 New Source - Recruitee [low-code SDK] (#18671)
  🎉 New source: Breezometer [low-code cdk] (#18650)
  Check disabled connections after protocol update (#18990)
  Simple default replication worker refactor (#19002)
  🎉 New Source: Visma e-conomic (#18595)
  🎉 New Source: Fastbill (#18593)
  Bmoric/extract state api (#18980)
  🎉 New Source: Zapier Supported Storage (#18442)
  🎉 New source: Klarna (#18385)
  `AirbyteEstimateTraceMessage` (#18875)
  Extract source definition api (#18977)
  [low-code cdk] Allow for spec file to be defined in the yaml manifest instead of an external file (#18411)
  🐛 Source HubSpot: fix property scopes (#18624)
  Ensure that only 6-character hex values are passed to monaco editor (#18943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp team/compose
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants