🪟 🔧 Add a start:cloud command to the webapp #19026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
team/compose
area/frontend
timroes
changed the title
timroes
commented
Nov 7, 2022
| @@ -9,6 +9,8 @@ | |||
| "prepare": "cd .. && husky install airbyte-webapp/.husky", | |||
| "prestart": "npm run generate-client", | |||
| "start": "craco start", | |||
| "prestart:cloud": "npm run generate-client", | |||
| "start:cloud": "AB_ENV=frontend-dev node -r ./scripts/environment.js ./node_modules/.bin/craco start", | |||
There was a problem hiding this comment.
ℹ️ Using AB_ENV here (we use AB across infra more commonly as an abbreviation of Airbyte), to not collide with the standardized ENV variable for production vs development.
There was a problem hiding this comment.
Somehow I had not yet realized what AB signified 😅
josephkmh
approved these changes
Nov 7, 2022
| @@ -9,6 +9,8 @@ | |||
| "prepare": "cd .. && husky install airbyte-webapp/.husky", | |||
| "prestart": "npm run generate-client", | |||
| "start": "craco start", | |||
| "prestart:cloud": "npm run generate-client", | |||
| "start:cloud": "AB_ENV=frontend-dev node -r ./scripts/environment.js ./node_modules/.bin/craco start", | |||
There was a problem hiding this comment.
Somehow I had not yet realized what AB signified 😅
Co-authored-by: Joey Marshment-Howell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This adds a
start:cloudcommand to the webapp. This makes it easier for employees to run the webapp in cloud mode, by simply runningnpm run start:cloud.The existing
npm startcommand will continue to work as it does today.How
The corresponding files will be checked into the (private) airbyte-cloud repository: https://github.com/airbytehq/airbyte-cloud/pull/3391
When running the command the
environment.jsfile will check if the airbyte-cloud repository is checked out in parallel (thus the file exists), and if so usedotenvto load it. This replaces the need for having any.env.developmentfile we need to copy around.Given that we can use different ports in those environment files (as the above linked PR already does), we can run Cloud and OSS also more easily in parallel in the future.