Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🎨 Adapt Osano banner to new UI #19029

Merged
merged 1 commit into from
Nov 7, 2022
Merged

🪟 🎨 Adapt Osano banner to new UI #19029

merged 1 commit into from
Nov 7, 2022

Conversation

letiescanciano
Copy link
Contributor

@letiescanciano letiescanciano commented Nov 7, 2022 •
edited
Loading

What

Adapt Osano banner to new UI 🎉
Screen Shot 2022-11-07 at 2 23 13 PM

@letiescanciano letiescanciano requested a review from a team as a code owner November 7, 2022 13:23
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp team/growth labels Nov 7, 2022
timroes
timroes approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, have not tested locally.

dizel852
dizel852 approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@dizel852 dizel852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍
Not tested locally

@letiescanciano letiescanciano merged commit 3aacda4 into master Nov 7, 2022
@letiescanciano letiescanciano deleted the fix/ui-changes-osano-dialog branch November 7, 2022 13:59
letiescanciano added a commit that referenced this pull request Nov 7, 2022
@letiescanciano
Merge branch 'master' into leti/experiment-add-source-in-signup
4127ba1 
* master:
  🪟 🎨 Adapt Osano banner to new UI (#19029)
  🪟 🔧 Add a start:cloud command to the webapp (#19026)
  🪟🧪 [Experiment] Move OAuth to top of signup page (#18899)
@github-actions github-actions bot mentioned this pull request Nov 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

@dizel852 dizel852 dizel852 approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform team/growth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@letiescanciano @timroes @dizel852