Use the source Ids when fetching catalog fetch events #19668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmoriceau
requested review from
colesnodgrass,
jdpgrailsdev,
gosusnp,
cgardens and
alovew
alovew
approved these changes
Nov 21, 2022
cgardens
approved these changes
Nov 21, 2022
gosusnp
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
@benmoriceau, just ran into this issue in the code, any reasons to not merge this?
|
FYI @benmoriceau and others on this PR, I borrowed from this PR plus another fix over in #21726 if you want to drop a review I can get it merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The use of the source Ids got lost during the PR updates, this is adding the a filtering on the source ids in the
getMostRecentActorCatalogFetchEventForSourcesmethod call.